Repository navigation
Add: light theme for the settings pages - #94
Merged
Merged
Conversation
Redeclare the palette, roles and semantic sets at their light values under html[data-theme="light"], and scope the admin page's overlays, elevation and surfaces to the same attribute. A Settings Display Mode row in Appearance selects System Default, Light or Dark. The choice is stored per device in localStorage and applied before the first paint by a classic script.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
html[data-theme="light"]intokens.css, with an increased-contrast partner for every light hue and a:root, html[data-theme="light"]selector list on theprefers-contrast: moreblock.--on-accentrole for ink on a filled control, and point the admin rules that drew--label-primaryon a coloured fill at it.--ov-soft/--ov/--ov-strong,--field-fill,--track-off,--scrim,--shadow-*) and give each a light value; no themed colour is left written into a rule.ui/js/theme.jsfor the mode logic andui/js/admin-theme.js, a blocking classic script that resolves the mode and writesdata-themeand thetheme-colormeta before the first paint.localStorageundersy-theme, applied on selection and followed live while the mode is System Default.palette-values.test.mjs.Testing
All green, except the Docker build smoke test, which has no local Docker and is left to CI. Added
ui/test/theme.test.mjs(12 tests), two light-theme contrast combinations plus an accent-as-text check, and two light reference-value tests.Checklist