Repository navigation
Fix: slider fill direction in right-to-left layouts - #99
Merged
Merged
Conversation
The native range handle reverses under RTL, but every gradient painted on a track was pinned to a physical direction, so the wallpaper brightness fill and the hue, saturation and brightness ramps ran against their handle. Drive all four from a --slider-dir token that flips to 270deg under [dir="rtl"], in CSS and in the JS that repaints the tracks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--slider-dirtoken toadmin.css, defaulting to90degand flipping to270degunder[dir="rtl"]..adm-rangetrack fill, the.hsb-hueramp, and the JS-drawn saturation and brightness ramps through that token instead of a fixedto right/90deg.Testing
All green. Added 2 frontend tests pinning the token's direction flip and rejecting any fixed-direction gradient on a slider track.
Checklist