Repository navigation
Fix: keep the feature badges styled on phones - #16
Merged
Merged
Conversation
The phone rules sized .badge from --sc, which only the demo screen defines. The badges in the badge feature resolved it to nothing and lost their size, radius and corner offset. Scope every phone rule to the demo screen.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.screen-inner, so.badgeoutside the demo keeps its own sizing.--scto nothing below 768px, dropping their size, radius, font size and corner offset, and leaving them square in the top-left of their anchor.Testing
All green:
npm run buildandnpm run checkboth pass. Verified in Chrome at 320, 390, 601 and 1280px: the feature badges are back to 20px with a -7px corner offset, and the demo badges still scale with the phone grid.Checklist
npm run buildandnpm run checkboth pass.