Repository navigation
Docs: describe the failure line a widget shows - #42
Merged
Merged
Conversation
The app no longer composes a widget's error text from the service's own message. It shows one line named after the kind of failure, and an empty result is drawn differently from a failed one. Correct the three places that quoted the old strings, and add a table of the lines a widget can show, with where to look for each. Re-sync the embedded widget code so the previews run the current version.
Deploying stackyard-docs with
|
| Latest commit: |
f87d200
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://bd2559a0.stackyard-docs.pages.dev |
| Branch Preview URL: | https://docs-widget-failure-messages.stackyard-docs.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The app stopped composing a widget's error text from the service's own message. A widget now keeps its layout, fades what it was showing, and puts one line named after the kind of failure where its own labels are. An empty result stays at full brightness and is drawn differently from a failure.
Not configuredis nowNot set up yet,Bad tokenis nowKey rejected, and there is noUnavailable.No data, each with its meaning and where to look. The existing table covers admin messages only, so these had nowhere to resolve to.Not reportingstate.ui/jsso the previews run the current version.Testing
npm run buildandnpm run checkboth pass. Checked in Chrome against the production build on the preview server, in both colour schemes and both docs themes. Verified every preview still renders: all 19 preview iframes have their data and config stubs, none shows a failure line, and the disk, backup, now-playing and weather previews were confirmed by eye. The night weather preview correctly takes the light caption ink while the two day previews take the dark one.Checklist
npm run buildandnpm run checkboth pass.