Repository navigation
Docs: read the landing page release badge from the app repository - #8
Merged
Merged
Conversation
Deploying stackyard-docs with
|
| Latest commit: |
5fda388
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://62b7a65c.stackyard-docs.pages.dev |
| Branch Preview URL: | https://docs-version-badge-from-app.stackyard-docs.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
readAppVersion()tosrc/lib/repo.ts, readingversionfrom the app repository'sapi/package.jsonand returning null when the checkout or the manifest is unreadable.data-versionattribute.verbadgerule toscripts/check-dist.mjsthat fails the build whendist/index.htmlships without a semver release badge, matching how the generated pages are already gated.Testing
All green:
npm run buildandnpm run checkboth pass withSTACKYARD_REPOset, and the badge rendersv1.7.1fromapi/package.json. Building with the checkout absent makes the new rule fail with exit 1, verified. Footer measured in Chrome in both colour schemes: badge geometry is unchanged at 107x23.Checklist
npm run buildandnpm run checkboth pass.