Repository navigation
Fix: link the landing page logo home and fix its landmarks - #88
Merged
Merged
Conversation
- Make the header logo a link to the home page, and play its animation on keyboard focus. - Move the header and footer out of the main region and name the navigation. - Match the landing page theme colour to its black background. - Send noindex on the pages.dev copy of the site.
SandObserver
added
accessibility
Deploying stackyard-docs with
|
| Latest commit: |
41b5bf4
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ade0cfe6.stackyard-docs.pages.dev |
| Branch Preview URL: | https://fix-landing-page-fixes.stackyard-docs.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.brandfrom adivto a link to/, with a hover colour lock so it keeps the label colour..orbit, on pointer hover and on:focus-visible.<main>so it wraps only the page content; the header nav and the footer now sit outside it. Label the nav "Main".theme-colorto#000000.X-Robots-Tag: noindexheader forhttps://:project.pages.dev/*inpublic/_headers.Testing
All green. Checked in Chrome at 1200 and 360 px: logo link, tab focus starts the orbit, nav and footer outside
main.Checklist
npm run buildandnpm run checkboth pass.