Repository navigation
fix(repo-map): ignore routes in comments and strings - #217
kspraveen-07 wants to merge 2 commits into
Conversation
|
@kspraveen-07 is attempting to deploy a commit to the Sandesh's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
ⓘ Qodo reviews are paused because your trial has ended. Ask your workspace admin to add credits to resume reviews. Manage billing |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
|
|
Hi @Sandesh13fr, the route-detection changes are complete, and all 78 repo-map tests pass locally. The CI test job is currently failing in |
|
Hi @Sandesh13fr, I investigated the failing CI checks. The two failures in |
|
Thanks @kspraveen-07 — the masking approach is right (checking
The red |
|
Hi @Sandesh13fr, I've fixed the Express block indentation and added the trailing newline to the test file. The repo-map test suite passes (78/78), and I've pushed the updates. Thanks for the review! |
What changed?
Fixed false-positive route detection in the repo-map package when route-looking text appears inside comments and string literals.
Fixes #178
Contribution prerequisite
Developmentbranch (unless a maintainer explicitly approved another base).Affected areas
packages/repo-mapValidation
pnpm buildpnpm testpnpm lintpnpm typecheckCommands run and results:
pnpm.cmd exec vitest run packages/repo-map/tests/symbols/detectFrameworkRoutes.test.ts— 7 tests passed.pnpm.cmd exec vitest run packages/repo-map/tests— 78 tests passed across 8 test files.git diff --check— no whitespace errors reported.Review notes