Skip to content

fix(cli): stop catalog tests failing as the bundled catalog ages - #266

Merged
Sandesh13fr merged 1 commit into
Developmentfrom
fix/218-catalog-freshness-tests
Nov 13, 2026
Merged

Sandesh13fr merged 1 commit into
Developmentfrom
fix/218-catalog-freshness-tests

Conversation

@Sandesh13fr

Copy link
Copy Markdown
Owner

Fixes #218.

Two catalog command tests and the CLI smoke catalog validate step checked the bundled catalog against the real clock. Once catalogs/models.json (updatedAt 2026-07-19) passed 90 days, they failed on every PR without any code changing.

  • catalogCommand.test.ts: pin now to the catalog's own updatedAt, read from the file so it survives catalog refreshes; add a test for an over-age catalog.
  • wma catalog validate: new --max-age-days <n> option (default 90, unchanged behavior).
  • smoke-cli.mjs: check the command runs, not the data age.

The catalog itself is still stale; refreshing model metadata needs a real review and is tracked separately.

Verified locally: vitest run 56 files / 542 tests pass, pnpm smoke:cli passes.

🤖 Generated with Claude Code

The catalog command tests and CLI smoke validated the bundled catalog
against the real clock, so every PR failed once catalogs/models.json
passed 90 days. Tests now pin the clock to the catalog's own updatedAt,
catalog validate gains --max-age-days (default 90), and smoke checks the
command runs without asserting data age.

Fixes #218

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@vercel

vercel Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
tcalc Ready Ready Preview Nov 13, 2026 10:36am UTC

@qodo-code-review

Copy link
Copy Markdown

ⓘ Qodo reviews are paused because your trial has ended. Ask your workspace admin to add credits to resume reviews. Manage billing

@coderabbitai

coderabbitai Bot commented Nov 13, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 8a0e39b8-aae1-4d71-9211-dfcd5714550f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@Sandesh13fr
Sandesh13fr merged commit f59e93a into Development Nov 13, 2026
12 checks passed
@Sandesh13fr
Sandesh13fr deleted the fix/218-catalog-freshness-tests branch November 13, 2026 10:39

This branch was successfully deployed

1 active deployment
Preview — f9ea6acd Deployed Nov 13, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant