Repository navigation
fix(cli): stop catalog tests failing as the bundled catalog ages - #266
Merged
Merged
Conversation
The catalog command tests and CLI smoke validated the bundled catalog against the real clock, so every PR failed once catalogs/models.json passed 90 days. Tests now pin the clock to the catalog's own updatedAt, catalog validate gains --max-age-days (default 90), and smoke checks the command runs without asserting data age. Fixes #218 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
ⓘ Qodo reviews are paused because your trial has ended. Ask your workspace admin to add credits to resume reviews. Manage billing |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #218.
Two catalog command tests and the CLI smoke
catalog validatestep checked the bundled catalog against the real clock. Oncecatalogs/models.json(updatedAt 2026-07-19) passed 90 days, they failed on every PR without any code changing.catalogCommand.test.ts: pinnowto the catalog's ownupdatedAt, read from the file so it survives catalog refreshes; add a test for an over-age catalog.wma catalog validate: new--max-age-days <n>option (default 90, unchanged behavior).smoke-cli.mjs: check the command runs, not the data age.The catalog itself is still stale; refreshing model metadata needs a real review and is tracked separately.
Verified locally:
vitest run56 files / 542 tests pass,pnpm smoke:clipasses.🤖 Generated with Claude Code