Skip to content

fix: handle catalog loading errors in validation - #271

Closed
Lakshanya25cs505 wants to merge 1 commit into
Sandesh13fr:mainfrom
Lakshanya25cs505:patch-1
Closed

Lakshanya25cs505 wants to merge 1 commit into
Sandesh13fr:mainfrom
Lakshanya25cs505:patch-1

Conversation

@Lakshanya25cs505

Copy link
Copy Markdown
  • Add error handling around loadModelCatalog().
  • Return a structured validation failure when catalog loading fails.
  • Include meaningful error messages for missing or invalid catalog files.
  • Preserve the existing JSON and text output formats.
  • Add validation for maxAgeDays and invalid dates.
  • Add debug logging when debug mode is enabled.

Closes #270

What changed?

Explain the problem, the approach, and any user-visible behavior. Link the issue: Fixes #... or Related to #....

Contribution prerequisite

  • I starred the TCalc repository before starting this contribution.
  • The linked issue is assigned to me, and this is my only open PR (drafts included).
  • This PR targets the Development branch (unless a maintainer explicitly approved another base).

Affected areas

Check all that apply, including downstream interfaces affected by shared-package changes.

  • CLI
  • MCP server / agent integrations
  • Web / dashboard
  • VS Code extension
  • JetBrains plugin
  • Shared package — specify:
  • GitHub Action / CI / release
  • Documentation / catalog data

Validation

List the exact commands run and their results. If a relevant check was not run, explain why.

  • Regression test added or updated for behavior changes
  • Relevant focused tests passed
  • pnpm build
  • pnpm test
  • pnpm lint
  • pnpm typecheck
  • The CI Success status check passes
  • CLI/MCP smoke, VSIX packaging, or JetBrains verification as applicable

Review notes

  • Privacy, security, compatibility, or breaking-change impact:
  • Documentation updated (or not needed because):
  • Screenshots/recording for visible UI changes (or not applicable):

- Add error handling around `loadModelCatalog()`.
- Return a structured validation failure when catalog loading fails.
- Include meaningful error messages for missing or invalid catalog files.
- Preserve the existing JSON and text output formats.
- Add validation for `maxAgeDays` and invalid dates.
- Add debug logging when debug mode is enabled.
@vercel

vercel Bot commented Nov 14, 2026

Copy link
Copy Markdown

@Lakshanya25cs505 is attempting to deploy a commit to the Sandesh's projects Team on Vercel.

A member of the Team first needs to authorize it.

@qodo-code-review

Copy link
Copy Markdown

ⓘ Qodo reviews are paused because your trial has ended. Ask your workspace admin to add credits to resume reviews. Manage billing

@github-actions

Copy link
Copy Markdown

This PR was closed by the contribution policy:

Please resolve the items above, then reopen the PR.

@github-actions github-actions Bot closed this Nov 14, 2026
@coderabbitai

coderabbitai Bot commented Nov 14, 2026 •

Copy link
Copy Markdown

Explain Change →

Caution

Review failed

The pull request is closed.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Handle catalog loading errors in executeCatalogValidate

1 participant