ci: deploy Japanese privacy page (/privacy/ja/) to Pages#84
Merged
Conversation
main's flasher.yml staged only the English privacy page, so the JA page (docs/manual/_pages/privacy/ja/index.html, added in #83) was never copied into _site — /privacy/ja/ returned 404 on production, and the "日本語" language switcher on the English privacy page was a dead link. Add the conditional ja copy step, matching develop's flasher.yml. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
3 tasks
Saqoosha
added a commit
that referenced
this pull request
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds the missing
japrivacy-page copy step to main'sflasher.yml.Why
PR #83 added the Japanese privacy page (
docs/manual/_pages/privacy/ja/index.html) to main, but main's Pages workflow only staged the English privacy page. Result:/privacy/ja/→ 404 on productiondevelop's
flasher.ymlalready has this step; this brings main in line (4-line conditional copy). CI/Pages only — no app, firmware, or manual changes.🤖 Generated with Claude Code