fix: replace llmforge local build context with Docker Hub image#640
fix: replace llmforge local build context with Docker Hub image#640codekite01 wants to merge 1 commit into
Conversation
📝 WalkthroughWalkthroughThe ChangesDocker Service Configuration
Estimated Code Review Effort🎯 1 (Trivial) | ⏱️ ~2 minutes
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #640 +/- ##
=========================================
Coverage 54.88% 54.88%
Complexity 663 663
=========================================
Files 91 91
Lines 3573 3573
Branches 395 395
=========================================
Hits 1961 1961
Misses 1435 1435
Partials 177 177 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
🧹 Nitpick comments (1)
docker-compose.yml (1)
58-58: ⚡ Quick winPin
sasanlabs/llmforgeto a digest (avoid:latest).
latestcurrently maps to:
- linux/amd64:
sha256:4813f5c0c2689dee2af2546506dd978e1343a2d178590c9c89353ace0f62fa1c- linux/arm64:
sha256:376255cfcb4472699ad9096b84889d416079bb5e1d1c7d422381bc0a39f88c19Replace
:latestwith the digest matching your targetos/arch(or addplatform:so Compose pulls the intended one).Suggested change
- image: sasanlabs/llmforge:latest + image: sasanlabs/llmforge@sha256:<digest matching your target os/arch>🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@docker-compose.yml` at line 58, Replace the floating image tag in the docker-compose service (image: sasanlabs/llmforge:latest) with a content-addressable digest or add an explicit platform to guarantee the correct architecture; for example, change the image reference to sasanlabs/llmforge@sha256:4813f5c0c2689dee2af2546506dd978e1343a2d178590c9c89353ace0f62fa1c for linux/amd64 (or use `@sha256`:376255cfcb4472699ad9096b84889d416079bb5e1d1c7d422381bc0a39f88c19 for linux/arm64) or keep the digest and add a platform: "linux/amd64" (or "linux/arm64") entry in the same service block so Compose pulls the exact image intended.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@docker-compose.yml`:
- Line 58: Replace the floating image tag in the docker-compose service (image:
sasanlabs/llmforge:latest) with a content-addressable digest or add an explicit
platform to guarantee the correct architecture; for example, change the image
reference to
sasanlabs/llmforge@sha256:4813f5c0c2689dee2af2546506dd978e1343a2d178590c9c89353ace0f62fa1c
for linux/amd64 (or use
`@sha256`:376255cfcb4472699ad9096b84889d416079bb5e1d1c7d422381bc0a39f88c19 for
linux/arm64) or keep the digest and add a platform: "linux/amd64" (or
"linux/arm64") entry in the same service block so Compose pulls the exact image
intended.
Problem
When cloning this repo individually and running
docker compose up,the llmforge service fails with:
unable to prepare context: path "../llmforge" not found
This is because it tries to build from a sibling directory that
doesn't exist in a standalone clone.
Fix
I tried Replacing the local build context with the pre-built image already
published on Docker Hub:
sasanlabs/llmforge:latestand it worked
References
Closes #629
Summary by CodeRabbit