Skip to content

fix: replace llmforge local build context with Docker Hub image#640

Open
codekite01 wants to merge 1 commit into
SasanLabs:masterfrom
codekite01:fix/llmforge-docker-build-context
Open

fix: replace llmforge local build context with Docker Hub image#640
codekite01 wants to merge 1 commit into
SasanLabs:masterfrom
codekite01:fix/llmforge-docker-build-context

Conversation

@codekite01
Copy link
Copy Markdown
Contributor

@codekite01 codekite01 commented May 23, 2026

Problem

When cloning this repo individually and running docker compose up,
the llmforge service fails with:
unable to prepare context: path "../llmforge" not found

This is because it tries to build from a sibling directory that
doesn't exist in a standalone clone.

Fix

I tried Replacing the local build context with the pre-built image already
published on Docker Hub: sasanlabs/llmforge:latest
and it worked

References

Closes #629

Summary by CodeRabbit

  • Chores
    • Updated service configuration to use a prebuilt container image instead of building from local source, enabling faster and more consistent deployments.

Review Change Stack

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 23, 2026

📝 Walkthrough

Walkthrough

The docker-compose.yml file is updated to configure the llmforge service to use a prebuilt Docker Hub image (sasanlabs/llmforge:latest) instead of building locally from ../llmforge, enabling the docker-compose setup to work out of the box without requiring the sibling directory to exist.

Changes

Docker Service Configuration

Layer / File(s) Summary
Service image configuration
docker-compose.yml
The llmforge service definition is changed from build: { context: ../llmforge } to image: sasanlabs/llmforge:latest, replacing local context-based builds with the prebuilt image from Docker Hub.

Estimated Code Review Effort

🎯 1 (Trivial) | ⏱️ ~2 minutes


🐰 A service that once required a distant sibling's care,
Now springs to life from clouds so fair,
No local paths to chase or seek,
Just pull the image—done in a blink, so sleek! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: replacing the local build context with a Docker Hub image for the llmforge service.
Linked Issues check ✅ Passed The code changes directly address the requirement in issue #629 by replacing the local build context with the pre-built Docker Hub image sasanlabs/llmforge:latest.
Out of Scope Changes check ✅ Passed The changes are limited to updating the llmforge service configuration in docker-compose.yml and are directly scoped to resolving the docker-compose build context issue.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 54.88%. Comparing base (266f41a) to head (81aead0).

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #640   +/-   ##
=========================================
  Coverage     54.88%   54.88%           
  Complexity      663      663           
=========================================
  Files            91       91           
  Lines          3573     3573           
  Branches        395      395           
=========================================
  Hits           1961     1961           
  Misses         1435     1435           
  Partials        177      177           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
docker-compose.yml (1)

58-58: ⚡ Quick win

Pin sasanlabs/llmforge to a digest (avoid :latest).

latest currently maps to:

  • linux/amd64: sha256:4813f5c0c2689dee2af2546506dd978e1343a2d178590c9c89353ace0f62fa1c
  • linux/arm64: sha256:376255cfcb4472699ad9096b84889d416079bb5e1d1c7d422381bc0a39f88c19

Replace :latest with the digest matching your target os/arch (or add platform: so Compose pulls the intended one).

Suggested change
-      image: sasanlabs/llmforge:latest
+      image: sasanlabs/llmforge@sha256:<digest matching your target os/arch>
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@docker-compose.yml` at line 58, Replace the floating image tag in the
docker-compose service (image: sasanlabs/llmforge:latest) with a
content-addressable digest or add an explicit platform to guarantee the correct
architecture; for example, change the image reference to
sasanlabs/llmforge@sha256:4813f5c0c2689dee2af2546506dd978e1343a2d178590c9c89353ace0f62fa1c
for linux/amd64 (or use
`@sha256`:376255cfcb4472699ad9096b84889d416079bb5e1d1c7d422381bc0a39f88c19 for
linux/arm64) or keep the digest and add a platform: "linux/amd64" (or
"linux/arm64") entry in the same service block so Compose pulls the exact image
intended.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@docker-compose.yml`:
- Line 58: Replace the floating image tag in the docker-compose service (image:
sasanlabs/llmforge:latest) with a content-addressable digest or add an explicit
platform to guarantee the correct architecture; for example, change the image
reference to
sasanlabs/llmforge@sha256:4813f5c0c2689dee2af2546506dd978e1343a2d178590c9c89353ace0f62fa1c
for linux/amd64 (or use
`@sha256`:376255cfcb4472699ad9096b84889d416079bb5e1d1c7d422381bc0a39f88c19 for
linux/arm64) or keep the digest and add a platform: "linux/amd64" (or
"linux/arm64") entry in the same service block so Compose pulls the exact image
intended.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: e93a6b18-d5ad-4802-a5b4-b12121ace269

📥 Commits

Reviewing files that changed from the base of the PR and between 266f41a and 81aead0.

📒 Files selected for processing (1)
  • docker-compose.yml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(docker): docker-compose fails due to missing llmforge build context

2 participants