Fix funded status, ledger resilience, orphan wallets, and platform ap…#136
Open
devsimze wants to merge 1 commit into
Open
Fix funded status, ledger resilience, orphan wallets, and platform ap…#136devsimze wants to merge 1 commit into
devsimze wants to merge 1 commit into
Conversation
…proval. Atomic campaign funding on payment, balance reconciliation, safer campaign creation errors, and fail-closed platform approver gating for withdrawals. Co-authored-by: Cursor <cursoragent@cursor.com>
|
@devsimze Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
handlePaymentatomically bumpsraised_amountand setsstatus = 'funded'when the target is reached. Funded campaigns still accept over-funding contributions without reverting toactive. SSE updates includestatusfor live UI refresh.activeandfundedcampaigns. Adds a 10-minutereconcileCampaignBalances()job that compares DBraised_amountto Horizon balances (existing stream reconnect + cursor replay unchanged).createCampaignWallet, returns 500 with a support message and logs the orphaned wallet public key for ops recovery.canPerformPlatformSignaturedenies all platform actions whenPLATFORM_APPROVER_USER_IDis unset. Withdrawals and milestones use the designated approver; startup warns on missing env;.env.exampledocuments production requirement.Closes #125
Closes #126
Closes #127
Closes #130
Test plan
npm testinbackend/— new/updated tests forledgerMonitor,campaigns, andwithdrawalsraised_amount >= target_amount; confirm status becomesfundedon detail page without manual DB editfundedandraised_amountincreasesPLATFORM_APPROVER_USER_IDset, confirm non-matching user gets 403 on platform approve/rejectPLATFORM_APPROVER_USER_IDunset, confirm platform approval is denied and startup warning is logged