fix: extend withdrawal XDR timeout to 7 days and add expiry guard#139
Open
OAKVISUALZ wants to merge 2 commits into
Open
fix: extend withdrawal XDR timeout to 7 days and add expiry guard#139OAKVISUALZ wants to merge 2 commits into
OAKVISUALZ wants to merge 2 commits into
Conversation
Closes Savitura#128 Changes: - stellarService.js: setTimeout(300) -> setTimeout(60*60*24*7) in buildWithdrawalTransaction; 5-minute window was too short for async multi-party signing where the platform approver may not be available for hours or days - stellarService.js: add isXdrExpired(xdr) helper that parses timeBounds from a raw XDR string and returns true if maxTime has passed; returns false on any parse error so a malformed XDR never blocks approval - withdrawals.js: call isXdrExpired before platform signs; return HTTP 410 with a clear re-request message if expired - WithdrawalsSection.jsx: track expired row IDs; detect 410 responses in runAction; show amber warning banner and Expired status label; hide admin approve+submit button for expired rows - withdrawals.test.js: add isXdrExpired stub; new test verifies 410 on expired XDR
|
@OAKVISUALZ Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
The admin moderation feature (feat: fb7f93d) accidentally introduced a corrupted section by merging two different versions of AdminDashboard — the old flat layout and the new tab-based layout were interleaved from line 476 onward, causing: frontend/src/pages/AdminDashboard.jsx 483:7 error Parsing error: Adjacent JSX elements must be wrapped in an enclosing tag This broke the frontend-checks CI step (ESLint exit code 1) for every subsequent PR. The fix removes the orphaned old-version JSX fragment (lines 476-622 of the corrupted file) which contained duplicate Platform Fees card, Campaign Management table, and Milestone Reviews section that had leaked out of the tab system into the outer render scope. The correct tab-based code remains intact. Frontend build: passed (built in 11.57s) Frontend ESLint: 0 errors, 0 warnings
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #128
Changes: