Skip to content

chore: fix event being empty for latest block#66

Merged
0xquantum3labs merged 1 commit into
mainfrom
chore/fix-block-number-problem
Sep 12, 2025
Merged

chore: fix event being empty for latest block#66
0xquantum3labs merged 1 commit into
mainfrom
chore/fix-block-number-problem

Conversation

@BaoHG1508
Copy link
Copy Markdown
Collaborator

@BaoHG1508 BaoHG1508 commented Sep 11, 2025

Description of change

Instead of passing the block number, using the block hash seems to solve the issue where we receive "empty" events list even though there's events and that's why we have to retry when received empty events list. Since we only need to fetch the latest block’s events, we don’t need ranged fetches using the block hash works fine.

Type of change (delete irrelevant types)

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have tested locally and linked a screen recording with this PR
  • I have adhered to clean code conventions
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works

Copy link
Copy Markdown
Collaborator

@metalboyrick metalboyrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@0xquantum3labs 0xquantum3labs merged commit e5b75f7 into main Sep 12, 2025
5 checks passed
@0xquantum3labs 0xquantum3labs deleted the chore/fix-block-number-problem branch September 12, 2025 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants