fix: properly stop event processing when indexer.stop() is called (SS2-145)#67
Merged
Merged
Conversation
Previously, calling indexer.stop() would not properly stop the onEvent handlers from processing new blocks. This was because: 1. The WebSocket subscription was never unsubscribed 2. The WebSocket connection was never disconnected 3. In-flight event handlers could still run after stop() was called This fix: - Adds early return in subscription handler when indexer is stopped - Unsubscribes from newHeads subscription before closing connections - Gracefully handles "Invalid subscription id" errors (code 66) - Disconnects WebSocket connection to prevent reconnection attempts Closes #54 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
metalboyrick
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of change
Previously, calling indexer.stop() would not properly stop the onEvent handlers from processing new blocks. This was because:
This fix:
Issue number
Closes #54
Type of change (delete irrelevant types)
Checklist: