Repository navigation
Connect with PKCE - #54
Merged
Merged
Conversation
…xchange its verifier, so an authorization code that ends up anywhere else cannot be exchanged for tokens
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
S2 of the API security review, plugin side: PKCE (RFC 7636, S256) for the connect flow.
code_challengeandcode_challenge_method=S256to the connect link.code_verifierin the code exchange. With no stored verifier, it sends none.The API binds the challenge to the code and only exchanges it with the matching verifier (Scanfully/api#323), so a code that ends up anywhere else is worthless. The dashboard passes the challenge on (Scanfully/dashboard#304).
Compatibility:
Tests: unit tests for the verifier storage, the RFC 7636 challenge vector, and the exchange body with and without a verifier.
composer test(196),phpcsandphpstanpass.