Repository navigation
Release 1.12.0: PHP error monitoring - #66
Merged
Merged
Conversation
…m before other plugins load, grouped and counted, credited to the plugin, theme or WordPress core that raised them, and sent to Scanfully with emails, keys, passwords and query strings removed
…ust-use plugin it adds, under External services
…aught by the must-use plugin and sent, and that without it the plugin still catches errors raised after plugins load
…arnings, counts that grow while errors are sent keep their sample, and long file paths in PHP error messages are no longer removed as keys
…ything Scanfully starts before other plugins load
…off, so it always runs while the site is connected
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PHP error monitoring, the plugin side.
scanfully-mu.php, towp-content/mu-pluginswhen that folder is writable. It removes the file when the plugin is deactivated, disconnected or deleted. Without it, errors raised after plugins load are still caught (coverage "partial").src/mu.phpfrom the plugin, which decides what starts before other plugins load (today the PHP error monitor), so a later feature that needs to run early changes the plugin, not the file on the site.Needs Scanfully API v2.7.0 or newer, which is live.
Tested
composer qa: lint and PHPStan clean, 741 unit tests pass.scanfully-mu.phpis removed on deactivate and on uninstall, written again on activate, and a file of that name that isn't Scanfully's is left alone.scanfully-mu.phpinstalled, stay connected and keep reporting. A test warning was caught, credited to the file that raised it, and shown in Scanfully with the query string removed from the URL path.