fix: cli.py not sending ALL_MESSAGES fix, walk-conversation, post db tests#1
Merged
Scarvy merged 2 commits intoScarvy:mainfrom Sep 2, 2025
Merged
fix: cli.py not sending ALL_MESSAGES fix, walk-conversation, post db tests#1Scarvy merged 2 commits intoScarvy:mainfrom
Scarvy merged 2 commits intoScarvy:mainfrom
Conversation
cli was not sending all messages to load messages causing it to load only first message and if the first message did not have parts it did not load anything. to verify i've added post db checks which load the most heavy conversation and outputs it result on the console in human readable format Also had to add a pytest.ini to support console logs to be shown in default pytest commnd
Owner
|
@isandesh7 Thanks for the PR! Tests failed looking for the database in the new pytest file you added. See below: I think adding a fixture to initialize a temporary database to run the sanity checks will fix it. After that it will be good to merge 👍. |
Contributor
Author
|
@Scarvy I have added the fixture. The tests pass now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cli was not sending all messages to load messages causing it to load only first message and if the first message did not have parts it did not load anything.
to verify i've added post db checks which load the most heavy conversation and outputs it result on the console in human readable format
Also had to add a pytest.ini to support console logs to be shown in default pytest commnd
I had made some fixes to load_document before observing the root cause.
I kept them since the tests are passing on those changes.