Overhaul Fujifilm ASCOM driver - #7
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
dotnet run --project tests/Fujicom.Core.Tests/Fujicom.Core.Tests.csproj --configuration Release— 8/8 checks passeddotnet msbuild Fuji/Fuji.csproj -t:Restore -p:BuildProjectReferences=falsedotnet msbuild Fuji/Fuji.csproj -t:Build -p:Configuration=Release -p:Platform=AnyCPU -p:BuildProjectReferences=false— managed ASCOM driver compiledpython3 build/verify-sdk-interop.py— 25 XAPI exports, 7 LibRaw exports, and 5 high-risk signature/constant contracts passedgit diff --check— cleanHardware-validation boundary
This environment cannot compile the x64 C++/CLI wrapper or exercise the proprietary USB protocol against a physical Fujifilm body. Before a 3.0 installer/release is cut, this should be built on Windows and smoke-tested with ASCOM Platform plus at least one GFX Bayer and one X-Trans camera. The PR is intentionally opened as a draft for that final validation.