fix(OnyxBasicDialog, OnyxModal): Fix OnyxModal closing on scrollbar click#5586
Draft
JoCa96 wants to merge 5 commits into
Draft
fix(OnyxBasicDialog, OnyxModal): Fix OnyxModal closing on scrollbar click#5586JoCa96 wants to merge 5 commits into
JoCa96 wants to merge 5 commits into
Conversation
🦋 Changeset detectedLatest commit: d4631f1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
JoCa96
force-pushed
the
joca96/5585-fix-onyx-modal-close-scrollbar-click
branch
2 times, most recently
from
4821fc9 to
2035239
Compare
JoCa96
force-pushed
the
joca96/5585-fix-onyx-modal-close-scrollbar-click
branch
from
0f9cae6 to
d4631f1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5585
Cause: The scrollbar belongs to the
dialogelement. For layout reasons only the.onyx-basic-dialog__contentelement is considered inside when determining an outside click. So clicking the scrollbar triggered an outside click.Fix: Move overflow handling and scrollbars to the content element.