Open
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR implements dual FastAPI/Flask support and updates the MySQL app skeleton while also applying various formatting improvements (e.g. consistent use of double quotes) in the codebase.
- Adds a FastAPI router in quantdb/router.py that mounts the Flask WSGI app
- Introduces a preliminary MySQL database module in quantdb/mysql_app, with code commented out pending further settings integration
- Applies consistent string literal formatting and minor comment adjustments in quantdb/ingest.py and updates pre-commit exclusions
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| quantdb/router.py | Adds a FastAPI router mounting the Flask app |
| quantdb/mysql_app/database.py | Provides a skeleton for database connection with commented code block |
| quantdb/mysql_app/init.py | Exports the database module |
| quantdb/ingest.py | Applies formatting updates (e.g. switch from single to double quotes) and minor comment fixes |
| quantdb/init.py | Adds a future-proof import for annotations |
| .pre-commit-config.yaml | Updates the exclusion regex to skip quantdb/ingest.py |
Comments suppressed due to low confidence (1)
quantdb/ingest.py:159
- The comment contains a typo: 'becase' should be changed to 'because' for clarity.
# FIXME bad becase left and right are unstable and we don't care about this, we just want relative to max possible
Collaborator
Author
|
@tmsincomb remove api.py from everything that is pre-commit. |
Collaborator
Author
|
@tgbugs I had vscode linter run when pre-commit did. The ignore works for pre-commit regarding api and I added ingest back in to be edited. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Will be updating dual FastAPI/Flask #12