Skip to content

Prod server#13

Open
tmsincomb wants to merge 16 commits intomasterfrom
prod-server
Open

Prod server#13
tmsincomb wants to merge 16 commits intomasterfrom
prod-server

Conversation

@tmsincomb
Copy link
Collaborator

@tmsincomb tmsincomb commented Apr 1, 2025

Will be updating dual FastAPI/Flask #12

  • merge blue update
  • merge new queries found in master

@tmsincomb tmsincomb self-assigned this Apr 1, 2025
@tmsincomb tmsincomb requested a review from Copilot April 28, 2025 20:43
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements dual FastAPI/Flask support and updates the MySQL app skeleton while also applying various formatting improvements (e.g. consistent use of double quotes) in the codebase.

  • Adds a FastAPI router in quantdb/router.py that mounts the Flask WSGI app
  • Introduces a preliminary MySQL database module in quantdb/mysql_app, with code commented out pending further settings integration
  • Applies consistent string literal formatting and minor comment adjustments in quantdb/ingest.py and updates pre-commit exclusions

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.

Show a summary per file
File Description
quantdb/router.py Adds a FastAPI router mounting the Flask app
quantdb/mysql_app/database.py Provides a skeleton for database connection with commented code block
quantdb/mysql_app/init.py Exports the database module
quantdb/ingest.py Applies formatting updates (e.g. switch from single to double quotes) and minor comment fixes
quantdb/init.py Adds a future-proof import for annotations
.pre-commit-config.yaml Updates the exclusion regex to skip quantdb/ingest.py
Comments suppressed due to low confidence (1)

quantdb/ingest.py:159

  • The comment contains a typo: 'becase' should be changed to 'because' for clarity.
# FIXME bad becase left and right are unstable and we don't care about this, we just want relative to max possible

@tmsincomb
Copy link
Collaborator Author

@tmsincomb remove api.py from everything that is pre-commit.

@tmsincomb
Copy link
Collaborator Author

@tgbugs I had vscode linter run when pre-commit did. The ignore works for pre-commit regarding api and I added ingest back in to be edited.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants