Draft
Conversation
This eliminates a warning from shapely deprecating the geos submodule.
The scaling we do with to_meter only works when the underlying eqc projection is operating on a sphere, not an ellipsoid.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternative to #2653. Here I've forced the use of a spherical datum with the equidistant cyindrical projection, which causes our scaling to work properly again.
This does result in one test failure, caused by the fact that the forced R parameter means the datum for the projection is always spherical, which flows downstream into all calls of
PlateCarree.to_geodetic().While this is a smaller change, my personal opinion is in favor of #2653 because we finally get rid of all the hacks we have been doing to try to make PlateCarree work using the eqc projection.