MNT: use github mirror for gshhg data download#2664
Open
greglucas wants to merge 1 commit intoSciTools:mainfrom
Open
MNT: use github mirror for gshhg data download#2664greglucas wants to merge 1 commit intoSciTools:mainfrom
greglucas wants to merge 1 commit intoSciTools:mainfrom
Conversation
greglucas
force-pushed
the
fix-gshhg-url
branch
from
c7a3cab to
9e15ec7
Compare
rcomer
approved these changes
Apr 12, 2026
Member
rcomer
left a comment
rcomer
left a comment
There was a problem hiding this comment.
Seems good to me, but I'll hold off from merging for a couple more days in case anyone else has an opinion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switch to the GitHub url for downloading gshhg data. I've left the version option in even though it isn't used now. It may help in the future or if we want to revert to a different url. We could also just hardcode this since the dataset is unlikely to change if that is preferable, I don't have a major preference either way.
closes #2657