Repository navigation
Recheck runs still recorded as running before the completed backlog - #22
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Last night's Nightly finished at 21:45 UTC, but collections at 00:47 UTC and later still showed it as in progress.
Why
A run's status changes only through the pending queue: run lists are read by creation time, so a run that was listed while running is updated only when its queued detail job is processed. The queue currently holds about 600 items, mostly completed runs whose reports are still to be read.
Each collection takes up to 30 items: runs the bot notified as reruns, then half "newest run ID" and half "oldest due". In practice a collection processes only 6–17 before the download budget runs out on report downloads.
Runs still recorded as running got no priority (the docs say they should). The Nightly was queued at 19:40, was neither among the newest IDs nor among the oldest due, and had not been processed once (
tries: 0).Change
Sync.pendingnow puts queued runs whose stored status is notcompleted(queued or in progress) right after the bot-notified reruns and ahead of the backlog, oldest due first. Re-reading them is what flips them to completed. Only the bounded rerun pass (only_priority) is unchanged. On the current queue this is three runs: last night's Nightly, a Real E2E run recorded as running since 2026-10-24, and a CI run.docs/incremental-history.mdstates the order.Validation
tests/test_run_changes.pytest: 39 completed runs wait, and run 20 was saved while running and has since finished. It fails onmain(run 40 is inspected first and run 20 is never reached withcount=4). With this change run 20 is inspected first, updated to completed/success, and leaves the queue.python3 -m unittest discover -s tests: 167 passed.test/score tests: OK.python3 test/journey-rerun-collection.py: OK.Release
Release category: release:fix
User impact: a workflow that finishes is shown as finished at the next collection, even with a large detail backlog.
Compatibility and migration: none.