chore(deps): migrate to lucide-react 1.x - #44
Merged
Conversation
lucide-react 1.x removed all brand/logo icons. Replace the two we used (Github, Twitter) with local inline SVG components — no new dependency: - add frontend/src/app/components/icons/BrandIcons.tsx (GithubIcon, XIcon; simple-icons paths, currentColor, className-compatible with lucide API) - AboutPage.tsx: Github -> GithubIcon (3 sites incl. ExtLink icon prop) - PopoversPage.tsx (UI demo): Twitter -> XIcon, Github -> GithubIcon - bump lucide-react ^0.577.0 -> ^1.17.0 Validated: frontend build (tsc, no missing exports), make lint (9/9).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of ISSUE_P (tier 2 of 3). lucide-react 1.x removed all brand/logo icons. We used two of them (
Github,Twitter).Change
Replaced with local inline SVG components — no new dependency added (a brand-icon package would be heavyweight for two glyphs):
frontend/src/app/components/icons/BrandIcons.tsx—GithubIcon+XIcon(simple-icons CC0 paths, 24×24,fill=currentColor,className-compatible so they drop into both JSX usage and theicon={...}component-reference prop).AboutPage.tsx—Github→GithubIcon(3 sites, incl.ExtLink icon={...}).PopoversPage.tsx(UI showcase/demo) —Twitter→XIcon,Github→GithubIcon.lucide-react^0.577.0→^1.17.0; lockfile regenerated.Twitter is rendered as the current X logo (brand was renamed). Only affected a demo page.
Validation
npm run build— OK (tsc -bconfirms no missing icon exports across all 141 icons we import)make lint— 9 linters, 0 errorsNote
peerDeps of lucide-react 1.17.0 (
react ^16.5.1 || 17 || 18 || 19) are satisfied by React 19 — no peer conflict.