-
-
Notifications
You must be signed in to change notification settings - Fork 48
Ping Protection V1.1 #171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: beta-discordjs14
Are you sure you want to change the base?
Ping Protection V1.1 #171
Conversation
…w file for correct tracking.
… advanced configuration in moderation.json and made the choices inside depend on it because I forgot to :/ Added the options to enable/disable pings/modlogs/logs kept after leave and made the choices depend on it + made those choices with numbers select instead of integers for almost 0 user-error issues.
…ded into the message editor for the warning message
…o debug code, has been tested and is currently ongoing extensive testing to ensure absolutely everythig works as supposed to
…lish while remaining the same functions. Removed a few locales that are unused and updated some locales for better understanding. Fully tested extensively. Not verified by GitHub because I code in VSCode.
…asic pings count config
Listed the warnings for all commands except the panel command as the bot already checks for administrator perms.
…s supposed to with SCNX.
…efault with the message content and allows to configure both options
…ge to the automod message block. Also the bot now deletes the rule it created if automod enabled = false
…imit reached with reply pings even when it's allowed in config
Added from my ping protection branch
…for days instead of weeks in the now renamed "useCustomTimeframe" instead of "advancedConfiguration"
…ually properly support multiple moderation actions (not tested before, and didn't work during testing)
… to make it work properly.
… waning message configuration and added an emoji to the why easter egg.
|
I noticed a few things I’d like to share regarding the module:
|
|
Hi Fridolin, |
|
Hi, thank you for your quick response. I think we should ask @SCDerox for the second question^^ |
|
Thanks for your valuable feedback, Fridolin. I, personally, have no issues with the limit. But based on your feedback, there's no technical reason that requires a limit. So making it adjustable and allowing users to disable it might be a compromise that both sides could agree on. |
|
I think I might just increase the limit to 2 years (48 months) and if we get any feedback from users for it to be longer then ig I can make it unlimited. But I agree with both 😅 |
|
Alrighty, I have now set the pings history limit to 2 years (I actually relaized it was only 6 months max, that was indeed short). Additionally, I removed the pings count thing for the custom timeframe as that's basically useless, it now uses the standard one, which is now also renamed to pingsCount without the Basic. |
|
Sorry, I forgot you were talking about moderation log |
|
Hi, I quickly added the category feature in the configuration.json and storage.json config files to make it look more sleek ^^ |
|
Thanks to Simon who provided me the list of emoji's that actually work in the dashboard, I adjusted it to use supported ones ^^ |
This is a small update to the current Ping Protection module.
This update includes the following changes:
I apologize for not catching these bugs in the initial release
No AI has been used this time.