reward system for level system #175

gg123bb · 2026-02-10T20:15:39Z

Summary

Add per-level reward roles with multiple roles per level.
Allow per-reward replacement behavior (replaceable vs. kept rewards).
Add /manage-levels rewards subcommands to manage rewards in Discord.
Update localization strings for the new reward commands.

Notes

Rewards now support multiple roles and per-level replace behavior.
Existing reward_roles/onlyTopLevelRole remains as fallback.

Testing

Used /manage-levels rewards add|set|remove|clear|list and verified config updates.

Copilot

Pull request overview

Adds a new reward-role configuration model for the levels module (multi-role rewards per level with optional “replace previous” behavior), and wires it into the level-up flow (message-based leveling and cheat-based level/xp edits). Also introduces a new config example file and localization keys intended for reward-management commands.

Changes:

Add modules/levels/rewards.js helper to resolve per-level rewards and compute replaceable role IDs (with legacy fallback to reward_roles/onlyTopLevelRole).
Update role-granting logic in messageCreate and manage-levels to use the new reward resolution.
Add configs/reward-roles.json config schema and extend locales with reward-management strings.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 7 comments.

Show a summary per file

File	Description
modules/levels/rewards.js	New reward resolution + replaceable-role computation with legacy fallback
modules/levels/module.json	Registers `configs/reward-roles.json` as a module config example file
modules/levels/events/messageCreate.js	Uses new reward resolution when granting/removing roles on level-up
modules/levels/configs/reward-roles.json	New config-element schema for per-level rewards (multi-role + replace flag)
modules/levels/commands/manage-levels.js	Updates cheat flows to apply reward roles via new reward helpers
locales/en.json	Adds new reward-management localization keys
locales/de.json	Adds new reward-management localization keys

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-10T20:25:37Z

modules/levels/commands/manage-levels.js

+            const rewardConfig = getRewardForLevel(interaction.client, user.level);
+            if (rewardConfig) {
+                if (rewardConfig.replacePrevious) {
+                    for (const role of getReplaceableRewardRoleIds(interaction.client)) {
                        if (member.roles.cache.has(role)) member.roles.remove(role, '[levels] ' + localize('levels', 'granted-rewards-audit-log')).catch();
                    }
                }
-                member.roles.add(interaction.client.configurations.levels.config.reward_roles[user.level.toString()]);
+                member.roles.add(rewardConfig.roles);
            }


member.roles.add(rewardConfig.roles) returns a Promise but isn’t awaited or caught. If adding the role(s) fails (missing permissions/unknown role), this can surface as an unhandled rejection. Please await it and/or attach .catch() (and consider passing an audit-log reason for consistency with message-based leveling).

Copilot · 2026-02-10T20:25:37Z

modules/levels/commands/manage-levels.js

            }
        }
-        member.roles.add(interaction.client.configurations.levels.config.reward_roles[user.level.toString()]);
+        member.roles.add(rewardConfig.roles);


member.roles.add(rewardConfig.roles) returns a Promise but isn’t awaited or caught. If adding the role(s) fails (missing permissions/unknown role), this can surface as an unhandled rejection. Please await it and/or attach .catch() (and consider passing an audit-log reason for consistency with message-based leveling).

Suggested change

member.roles.add(rewardConfig.roles);

await member.roles.add(rewardConfig.roles, '[levels] ' + localize('levels', 'granted-rewards-audit-log')).catch();

Copilot · 2026-02-10T20:25:38Z

modules/levels/commands/manage-levels.js

 const {registerNeededEdit} = require('../leaderboardChannel');
 const {localize} = require('../../../src/functions/localize');
 const {formatDiscordUserName} = require('../../../src/functions/helpers');
+const {getReplaceableRewardRoleIds, getRewardForLevel} = require('../rewards');



PR description mentions adding /manage-levels rewards ... subcommands, and new locale keys for reward-management commands were added, but manage-levels.js currently only defines reset-xp, edit-xp, and edit-level options (no rewards subcommand group). Either implement and register the rewards subcommands in this PR, or update the PR description/remove unused locale keys to avoid drifting docs/UI text.

Copilot · 2026-02-10T20:25:38Z

modules/levels/rewards.js

+function getReplaceableRewardRoleIds(client) {
+    const moduleConfig = client.configurations['levels']['config'];
+    const rewardEntries = getRewardEntries(client);
+    const roles = new Set();
+    if (rewardEntries.length !== 0) {
+        for (const entry of rewardEntries) {
+            if (!entry.replacePrevious) continue;
+            if (!Array.isArray(entry.roles)) continue;
+            for (const roleId of entry.roles) roles.add(roleId);
+        }
+    } else if (moduleConfig.reward_roles) {
+        for (const roleId of Object.values(moduleConfig.reward_roles)) roles.add(roleId);
+    }


getReplaceableRewardRoleIds/getRewardForLevel treat an empty levels['reward-roles'] array the same as “not configured” and fall back to legacy config.reward_roles. Because config-element files are always loaded as an array (often [] by default), there’s no way to intentionally disable rewards via the new config if legacy reward_roles is still populated (e.g., after using a future “clear” command). Consider distinguishing “missing/undefined” from “configured but empty” (e.g., have getRewardEntries return null when the config key is absent/not an array, and only fall back to legacy in that case), or add an explicit flag controlling legacy fallback.

Copilot · 2026-02-10T20:25:38Z

modules/levels/rewards.js

+function getRewardForLevel(client, level) {
+    const moduleConfig = client.configurations['levels']['config'];
+    const rewardEntries = getRewardEntries(client);
+    const entry = rewardEntries.find(r => parseInt(r.level) === level);


Level lookup uses parseInt(r.level) === level, which can match unexpected strings like "10abc" and omits an explicit radix. Prefer strict numeric coercion/validation (e.g., Number(r.level) with Number.isInteger) before comparing to level.

Suggested change

const entry = rewardEntries.find(r => parseInt(r.level) === level);

const entry = rewardEntries.find(r => {

const rLevel = Number(r.level);

return Number.isInteger(rLevel) && rLevel === level;

});

Copilot · 2026-02-10T20:25:38Z

modules/levels/rewards.js

+    const roles = new Set();
+    if (rewardEntries.length !== 0) {
+        for (const entry of rewardEntries) {
+            if (!entry.replacePrevious) continue;
+            if (!Array.isArray(entry.roles)) continue;
+            for (const roleId of entry.roles) roles.add(roleId);
+        }
+    } else if (moduleConfig.reward_roles) {
+        for (const roleId of Object.values(moduleConfig.reward_roles)) roles.add(roleId);
+    }
+    return [...roles];


Replacement logic builds a flat set of “replaceable role IDs” across all entries with replacePrevious: true. If the same role ID is ever used in both a replaceable reward and a non-replaceable (“kept”) reward, leveling into a replaceable reward will remove that role even if the member has it due to the kept reward. Consider enforcing uniqueness of role IDs across rewards, or tracking replaceability per (level, role) instead of per role ID.

Suggested change

const roles = new Set();

if (rewardEntries.length !== 0) {

for (const entry of rewardEntries) {

if (!entry.replacePrevious) continue;

if (!Array.isArray(entry.roles)) continue;

for (const roleId of entry.roles) roles.add(roleId);

}

} else if (moduleConfig.reward_roles) {

for (const roleId of Object.values(moduleConfig.reward_roles)) roles.add(roleId);

}

return [...roles];

// Track roles that are ever granted with replacePrevious = true vs false

const replaceableRoles = new Set();

const keptRoles = new Set();

if (rewardEntries.length !== 0) {

for (const entry of rewardEntries) {

if (!Array.isArray(entry.roles)) continue;

if (entry.replacePrevious) {

for (const roleId of entry.roles) {

if (roleId) replaceableRoles.add(roleId);

}

} else {

for (const roleId of entry.roles) {

if (roleId) keptRoles.add(roleId);

}

}

}

} else if (moduleConfig.reward_roles && moduleConfig.onlyTopLevelRole) {

// Legacy configuration: only treat roles as replaceable when legacy

// behavior (onlyTopLevelRole) indicates previous roles should be replaced.

for (const roleId of Object.values(moduleConfig.reward_roles)) {

if (roleId) replaceableRoles.add(roleId);

}

}

// A role is considered replaceable only if it is never used in a non-replacePrevious entry.

const effectiveReplaceableRoles = [];

for (const roleId of replaceableRoles) {

if (!keptRoles.has(roleId)) {

effectiveReplaceableRoles.push(roleId);

}

}

return effectiveReplaceableRoles;

Copilot · 2026-02-10T20:25:39Z

modules/levels/events/messageCreate.js

                }
            }
-            await msg.member.roles.add(moduleConfig.reward_roles[user.level.toString()], '[levels]' + localize('levels', 'granted-rewards-audit-log')).catch();
+            await msg.member.roles.add(rewardConfig.roles, '[levels]' + localize('levels', 'granted-rewards-audit-log')).catch();


The audit-log reason for adding roles is "[levels]" + localize(...) (missing a space after the tag), while the removal reason uses "[levels] " + .... Consider making these consistent so audit logs read correctly.

gg123bb added 2 commits February 10, 2026 19:24

Add per-level reward roles and reward commands

ffb215d

Remove reward config subcommands from manage-levels

407d6d4

SCDerox requested a review from Copilot February 10, 2026 20:20

Copilot started reviewing on behalf of SCDerox February 10, 2026 20:21 View session

Copilot AI reviewed Feb 10, 2026

View reviewed changes

Moderation: linked accounts, automod, dossiers, tools

781783e

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

reward system for level system #175

reward system for level system #175

Uh oh!

gg123bb commented Feb 10, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Feb 10, 2026

Uh oh!

Copilot AI Feb 10, 2026

Uh oh!

Copilot AI Feb 10, 2026

Uh oh!

Copilot AI Feb 10, 2026

Uh oh!

Copilot AI Feb 10, 2026

Uh oh!

Copilot AI Feb 10, 2026

Uh oh!

Copilot AI Feb 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

	member.roles.add(rewardConfig.roles);
	await member.roles.add(rewardConfig.roles, '[levels] ' + localize('levels', 'granted-rewards-audit-log')).catch();

-    const entry = rewardEntries.find(r => parseInt(r.level) === level);
+    const entry = rewardEntries.find(r => {
+        const rLevel = Number(r.level);
+        return Number.isInteger(rLevel) && rLevel === level;
+    });

-    const roles = new Set();
-    if (rewardEntries.length !== 0) {
-        for (const entry of rewardEntries) {
-            if (!entry.replacePrevious) continue;
-            if (!Array.isArray(entry.roles)) continue;
-            for (const roleId of entry.roles) roles.add(roleId);
-        }
-    } else if (moduleConfig.reward_roles) {
-        for (const roleId of Object.values(moduleConfig.reward_roles)) roles.add(roleId);
-    }
-    return [...roles];
+    // Track roles that are ever granted with replacePrevious = true vs false
+    const replaceableRoles = new Set();
+    const keptRoles = new Set();
+    if (rewardEntries.length !== 0) {
+        for (const entry of rewardEntries) {
+            if (!Array.isArray(entry.roles)) continue;
+            if (entry.replacePrevious) {
+                for (const roleId of entry.roles) {
+                    if (roleId) replaceableRoles.add(roleId);
+                }
+            } else {
+                for (const roleId of entry.roles) {
+                    if (roleId) keptRoles.add(roleId);
+                }
+            }
+        }
+    } else if (moduleConfig.reward_roles && moduleConfig.onlyTopLevelRole) {
+        // Legacy configuration: only treat roles as replaceable when legacy
+        // behavior (onlyTopLevelRole) indicates previous roles should be replaced.
+        for (const roleId of Object.values(moduleConfig.reward_roles)) {
+            if (roleId) replaceableRoles.add(roleId);
+        }
+    }
+    // A role is considered replaceable only if it is never used in a non-replacePrevious entry.
+    const effectiveReplaceableRoles = [];
+    for (const roleId of replaceableRoles) {
+        if (!keptRoles.has(roleId)) {
+            effectiveReplaceableRoles.push(roleId);
+        }
+    }
+    return effectiveReplaceableRoles;

Uh oh!

reward system for level system #175

Are you sure you want to change the base?

reward system for level system #175

Uh oh!

Conversation

gg123bb commented Feb 10, 2026

Summary

Notes

Testing

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Feb 10, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 10, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 10, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 10, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 10, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 10, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 10, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant