Repository navigation
Fix Andere Kombinationen button - #51
Conversation
9a3a9eb to
38036b6
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9a3a9eb00e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const storedRanked = rankStoredMatchesWithPreferences( | ||
| rankStoredRecipes(filtered, { limit: 24 }), | ||
| preferences, | ||
| ) | ||
| .slice(0, 4) | ||
| .map((match) => recommendationFromStoredMatch(match, pantry.servings)); | ||
| ); |
There was a problem hiding this comment.
When a user has marked many highly ranked recipes as do_not_suggest, this limits the matches to 24 before rankStoredMatchesWithPreferences removes those recipes. For example, suppressing the first 20 matches leaves only four entries in storedRanked, even though eligible matches ranked 25 and below still exist; if the generated set is stable, every page is then identical and the screen hides “Andere Kombinationen.” Filter disallowed recipes before applying the limit so pagination can reach the remaining recommendations.
Useful? React with 👍 / 👎.
Der Button Andere Kombinationen hat bisher nur den Generator-Seed verändert. Wenn keine generierten Kandidaten vorhanden waren, blieb die sichtbare Rezeptliste deshalb vollständig unverändert.
Änderungen: