Skip to content

Fix launcher icon PNG compatibility and publish v1.0.3 - #54

Merged
ScoreSymphony merged 3 commits into
mainfrom
fix/jimp-safe-launcher-icon-v1.0.3
Sep 22, 2026
Merged

ScoreSymphony merged 3 commits into
mainfrom
fix/jimp-safe-launcher-icon-v1.0.3

Conversation

@ScoreSymphony

Copy link
Copy Markdown
Owner

Fixes the remaining launcher-icon release blocker after v1.0.2.

Root cause

The selected Fruit Fusion artwork was restored, but that PNG encoding is rejected by Expo/Jimp during Android prebuild with Unrecognised filter type - 115. As a result, the v1.0.2 publish workflow failed before an APK could be produced.

Fix

  • re-encode the selected transparent Fruit Fusion artwork as a standards-compliant non-interlaced 8-bit RGBA PNG
  • keep the icon source at assets/branding/smoothie-generator-icon.png
  • add PNG validation to the mobile release audit, including scanline filter validation
  • bump app/package to v1.0.3
  • bump Android versionCode to 4 and iOS build number to 4
  • add v1.0.3 release notes

No domain/application logic is changed.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6a5c4fe084

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread scripts/release-audit.mjs
if (!existsSync(join(root, iconPath))) {
fail(`configured application icon does not exist: ${iconPath}`);
}
const iconInfo = validatePng(iconPath);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Commit a complete PNG before enforcing the audit

The committed icon is only 7,505 bytes, while its first IDAT chunk declares a 32,354-byte payload (requiring at least 32,399 bytes through that chunk), so validatePng always throws application icon contains a truncated PNG chunk. Because the release workflow runs npm run audit:release before building, every v1.0.3 release attempt is blocked; replace the truncated asset with the complete re-encoded PNG.

Useful? React with 👍 / 👎.

@ScoreSymphony
ScoreSymphony merged commit 59ee3fe into main Sep 22, 2026
1 check passed
@ScoreSymphony
ScoreSymphony deleted the fix/jimp-safe-launcher-icon-v1.0.3 branch September 22, 2026 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant