Repository navigation
Fix launcher icon PNG compatibility and publish v1.0.3 - #54
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6a5c4fe084
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (!existsSync(join(root, iconPath))) { | ||
| fail(`configured application icon does not exist: ${iconPath}`); | ||
| } | ||
| const iconInfo = validatePng(iconPath); |
There was a problem hiding this comment.
Commit a complete PNG before enforcing the audit
The committed icon is only 7,505 bytes, while its first IDAT chunk declares a 32,354-byte payload (requiring at least 32,399 bytes through that chunk), so validatePng always throws application icon contains a truncated PNG chunk. Because the release workflow runs npm run audit:release before building, every v1.0.3 release attempt is blocked; replace the truncated asset with the complete re-encoded PNG.
Useful? React with 👍 / 👎.
Fixes the remaining launcher-icon release blocker after v1.0.2.
Root cause
The selected Fruit Fusion artwork was restored, but that PNG encoding is rejected by Expo/Jimp during Android prebuild with
Unrecognised filter type - 115. As a result, the v1.0.2 publish workflow failed before an APK could be produced.Fix
assets/branding/smoothie-generator-icon.pngversionCodeto 4 and iOS build number to 4No domain/application logic is changed.