Draft
Conversation
Fixes some issues with the clock, add a setting to control whether the clock is displayed.
Owner
|
Hi @ScanuNicco Sorry for the late response. Unfortunately I'm no longer looking to maintain or update this app and will not be deploying updated changes to the Play Store. I hope you can understand. That said, this is an awesome feature and I'd love to merge it when you think it's ready. People are still stumbling across this repo and I think it would be valuable to include your PR. |
Author
|
I totally understand, I know that these kinds of projects can be a big commitment. As for the PR, I've been using it for a while now and it seems to be working pretty well. I think all I need to do is add support for 24-hour time and it will be good to go. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I use my Kindle as a digital photo frame and I wanted to have a clock displayed with my photos, so I went ahead and added one. Still have to add a toggle to settings so I'm making this PR a draft for now, but I wanted to know your opinion on this feature before I implement that.
