fix: trigger publish workflows on lerna tag format - #3
Merged
Conversation
The JS publish workflows triggered on 'sdk-<name>/v*' tags, but lerna (independent mode) creates tags as '@screeb/<name>@<version>', so the workflows never ran on release. Align the 5 JS workflow triggers to lerna's actual tag format. Also remove the root 'publish' script: with CI publishing on tag push, 'npm run version' (tags only) is the documented flow, and the local 'lerna publish' would double-publish.
Alexays
pushed a commit
that referenced
this pull request
Jul 9, 2026
fix: trigger publish workflows on lerna tag format
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The five JS SDK publish workflows (angular, browser, react, vue, react-native) never run on release. They trigger on tags like `sdk-/v*`, but the documented release flow (`npm run version` → Lerna in independent mode) creates tags as `@screeb/@`. No Lerna tag ever matched the trigger patterns, so the workflows never fired.
Existing tags confirm the format: `@screeb/sdk-react@0.7.0`, `@screeb/react-native@3.3.0`, `@screeb/sdk-browser@0.6.0`, etc.
Flutter and MAUI are unaffected — `CONTRIBUTING.md` documents tagging those manually as `sdk-flutter/vX.Y.Z` / `sdk-maui/vX.Y.Z`, which already matches their triggers.
Changes
The glob patterns are scoped per-package — e.g. `@screeb/sdk-angular@*` does not match `@screeb/sdk-angular-example@...` (the char after the package name must be `@`).
Follow-up (not in this PR)
npm trusted publishing: the workflows use `--provenance` + OIDC (`id-token: write`). Each package must have a trusted publisher configured on npmjs.com pointing at its workflow file, or the publish step will fail at auth on the first run.
Verification