fix: build full workspace before publishing - #5
Merged
Conversation
Packages sdk-react/sdk-angular/sdk-vue depend on the workspace package @screeb/sdk-browser, whose dist/types must exist at build time. Building only the target workspace (npm run build --workspace=...) fails to resolve @screeb/sdk-browser. Build the whole workspace (npm run build, topological via lerna, same as CI) so dependencies are built first.
Alexays
pushed a commit
that referenced
this pull request
Jul 9, 2026
fix: build full workspace before publishing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #4. After #4, OIDC publishing worked —
@screeb/sdk-browser@0.6.1and@screeb/react-native@3.3.1published successfully. Butsdk-react,sdk-angular, andsdk-vuefailed at the build step:Those three depend on the workspace package
@screeb/sdk-browser, whosedist/type declarations must exist at build time. The publish step built only the target workspace (npm run build --workspace=...), so the dependency was never built. (browser has no internal dep; react-native doesn't import sdk-browser types — both built fine.)Fix: build the whole workspace with
npm run build(topological via lerna, identical toci.yml) so dependencies are built before the target package. Applied to all 5 JS publish workflows for consistency.After merge
Re-trigger the 3 remaining tags (
@screeb/sdk-react@0.7.1,@screeb/sdk-angular@0.6.1,@screeb/sdk-vue@0.2.1) by re-pointing them to merged master and pushing individually. (sdk-browser and react-native are already on npm — leave them.)