chore: delete dead modules, exports, fixtures, scripts, and unused dependencies - #654
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 77bb1b6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
ScriptedAlchemy
force-pushed
the
chore/ponytail-dead-code
branch
from
September 6, 2026 00:24
d42a2a3 to
6f33143
Compare
commit: |
ScriptedAlchemy
force-pushed
the
chore/ponytail-dead-code
branch
from
September 6, 2026 00:29
6f33143 to
a063d6c
Compare
ScriptedAlchemy
marked this pull request as ready for review
September 6, 2026 00:33
ScriptedAlchemy
enabled auto-merge (squash)
September 6, 2026 00:33
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Deletes code, fixtures, scripts, and dependencies that nothing in the repository reaches. Every item was re-verified with
git grep -n -w '<name>' -- ':!repos'before deletion; the only references were the definition itself, its own test cases, or prose in historicaldocs/superpowers/**plans.docs/canvases/agent-bundle-walkthrough.canvas.tsx,packages/agent-bundle/fixtures/contracts/epoch-atomicity/local-linux.json,scripts/measure-preflight-cold-start.mjs,packages/agent-bundle/src/core/durability-test-hook.ts,packages/agent-bundle/src/contracts/playground.ts— zero importers or invokers (theSymbol.for('…durability-test-hook')strings in the stores are unrelated).bench:preflight-cold-start(script deleted) andtest:host-install:packed:build(zero refs). Addedrecord:claude-hooks-fixturessoscripts/record-claude-hooks-schema-fixtures.mjs, the recorder named byadapters/schemas/claude/PROVENANCE.json, is reachable frompackage.json.core/durable-fs.ts: the only production importer isdev/dev-lock.ts(publishFileByLink). DeletedsyncDirectorySync,writeJsonFileAtomically,writeNewPinnedFile,openPinnedContainedFile,readPinnedFile,readTornTailJsonland their option types; keptsyncPath(used bypublishFileByLink). Header comment no longer claims the playground/eval/epoch stores use these.core/owner-lock.ts: deletedOwnerMutationSerializerandsharedOwnerMutationSerializer(test-only).core/strict-json.ts: deletedisStrictJsonValue.dev/mcp-apps/mcp-app-sandbox.ts: deletedcreateMcpAppSandboxBridge, its types (McpAppSandboxBridge,CreateMcpAppSandboxBridgeOptions,McpAppSandboxLifecycle,McpAppSandboxMessage,McpAppSandboxMessageEvent,McpAppSandboxResource,McpAppSandboxWindow,McpAppSandboxRequestId), and the private JSON-RPC helpers only the bridge used. The proxy, frame, policy, and consent surface is untouched.dev/mcp-apps/mcp-app-json.ts: deletedrequireMcpAppJsonRecord(no importer;mcp-app-action-validation.tsdefines its own record guard).cloneMcpAppJson,snapshotMcpAppJson,snapshotMcpAppJsonRecord, andMcpAppJsonRecordwere dead when this PR opened but refactor(agent-bundle): dedupe route, JSON, and IP-range helpers onto shared owners #660 rewiredmcp-app-bridge.tsonto them, so the merge frommainrestores them.schemas/skill-hosts/contract.ts: deleted thevalidatePortableSkillFrontmatteralias.test/registry.ts: deletedhasRegisteredRoutes.effect/boundary.ts(agent-bundle): deletedinterruptWhenAborted,abortToInterrupt,interruptAs,runPromiseExit— zero production callers. (rsc-runtime): deletedrunPromiseExit,runSync;interruptWhenAborted/abortToInterruptstay (live inproject-mcp.tsandreconciler.ts). Two tests that usedrunPromiseExitincidentally to inspect anExitnow userunPromise(Effect.exit(…)), the pattern already ineffect-platform.test.ts.rsc-runtime/src/effect/render-stream.ts: deletedboundRenderEventStream(emitBoundRenderEventstays, used byreconciler.ts).eventsForActiveEvalRun,discardedSequenceForActiveEvalRun(evals-page.tsx) andproblemFailureCount(build-status-model.ts).openfrompackages/agent-bundle(only'open'string literals remain, used as a shell command name),schedulerfrompackages/workbench(zero imports; still resolved transitively byreact-dom), andcommanderfrom rootdevDependencies(its only importer,src/cli.ts, declares it inpackages/agent-bundle/package.json).pnpm installrefreshedpnpm-lock.yaml.docs/effect-conventions.mdandagent-patterns/effect-errors.mdthat namedrunPromiseExit/boundRenderEventStreamnow name the surviving helpers.Dead-module check after deletion:
git grep -l '<stem>' -- ':!repos'for every deleted stem returns only the expected unrelated hits (historical plan docs,Effect.runPromiseExitinside the boundaries, the lint rule's banned-name list).Validation
All green: 283 files, 4227 tests, 0 failures. One earlier
test:unitrun had a single unrelated timing flake inmcp-probe-service.test.ts("removes the fresh plugin data directory after every probe"); it passed 3/3 in isolation and on the full-suite rerun, and its module imports nothing this PR touched.Deslop
Deslop: Claude Fable 5.1, 1 edit (dropped a header sentence in
durable-fs.tsthat restated theDurableHandleOpendoc line).Self-review
Reviewer: GPT-5.6 Sol (
generalPurpose; the TraceDecay-backedchange-risk-reviewerwas unavailable). Findings and disposition:package.jsongainsrecord:claude-hooks-fixtures— dismissed, intentional: the script is the recorderadapters/schemas/claude/PROVENANCE.jsonnames; wiring it is the alternative to deleting a documented tool.3–5.
docs/superpowers/plans/2026-08-14-…,plans/2026-08-19-durable-filesystem-plan.md,specs/2026-08-19-thermo-review-refactors-design.mdstill namecreateMcpAppSandboxBridge/syncDirectorySync— dismissed: dated historical plans and specs, not reference docs; the docs rule coverswebsite/docs/**and reference prose, both of which never mentioned these names.No surviving production callers, weakened tests, or dependency-import regressions were found.
Second pass after the changeset rewrite (same reviewer): no merge risks found.
Merged
origin/mainafter #655/#657/#660 landed: one textual conflict inmcp-app-sandbox.ts(helpers this PR deletes, which #660 had modified — deletion kept) and one semantic conflict inmcp-app-json.ts(above). Full gate re-run green locally (build, typecheck, lint, 4223 unit tests) before push.