refactor: remove legacy API compatibility paths - #810
Open
ScriptedAlchemy wants to merge 11 commits into
Open
ScriptedAlchemy wants to merge 11 commits into
ScriptedAlchemy wants to merge 11 commits into
Conversation
🦋 Changeset detectedLatest commit: 19ab901 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
commit: |
AB5000 rejected examples/mcp-app (and the same duplicate landed in hooks-and-scripts / skills-starter) after the plugin.version migration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove deprecated compatibility APIs after migrating every in-repository caller. Package versions now come only from
package.json, generated MCP tools use directdefineTool(...)definitions, and runtime consumers use Agent Documents/projectors instead of the removed JSX lowerers.Removal matrix
plugin.versionpackage.json.versionin examples, fixtures, benchmarks, Workbench tests, integration tests, and packed consumersAB4008;AB4001now rejects the retired key so un-typechecked configs cannot silently ignore it;resolvePluginVersiondeletedexport default defineTool({ inputSchema, resultSchema, ... }, handler)definitionsconfig/execute/rendersplit contract--forcealias--replacefor installationagent-bundle install <host> --forceand standalone installer install-mode aliasServedAppServedMcpAppisTtycallbacksterminalor process probingRunGeneratedCliOptions.isTtyandRunGeneratedRenderedScriptOptions.isTtyAB4827now names the route-relative pathagent()Hook,Mcp,lowerHookResult,NativePostToolUseOutput,lowerMcpResult,createRscRequestContext,RscRequestContextAgentDocumentSnapshotAgentDocumentMcpAppHostProfile,PlaygroundStore,McpConfigDownload, Workbench feature aggregate andProjectClient.connect(..., onEvent)Kept with justification
--force: required to safely inspect, upgrade, or remove on-disk installs without deleting foreign data.AB4001as a retired-key error only: config loading does not runtsc, so this guard prevents a lingeringplugin.versionfrom being silently ignored; it does not restore authored-version behavior.Independent review
Fable
change-risk-reviewer: one medium and two low findings.plugin.versionignore. Any own retired key now fails closed withAB4001; test, changeset, diagnostics source, and en/zh docs agree.InstallBundleOptions.replaceJSDoc no longer advertises install--force.defineToolauthoring remains documented in both locales.Verification
Final tip
5a4ae0a782afca3e264b42c07a7c3f3866ce074f, rebased on currentorigin/main:pnpm build && pnpm typecheck && pnpm lint && pnpm test:unit— pass (307 files; 4,458 tests, 4,452 passed, 6 skipped)pnpm test:integration— pass (104 files; 1,185 tests, 1,181 passed, 4 skipped)pnpm check:release:ci— pass (packed pool: 16 files; 47 tests, 46 passed, 1 skipped; package/declaration checks passed)pnpm docs:site:build— pass (0 locale drift failures, diagnostics coverage complete, 0 broken links across 30,527 anchors)