Skip to content

test(doctor): isolate Codex fixture from operator receipts - #829

Merged
ScriptedAlchemy merged 1 commit into
mainfrom
codex/doctor-ci
Sep 18, 2026
Merged

ScriptedAlchemy merged 1 commit into
mainfrom
codex/doctor-ci

Conversation

@ScriptedAlchemy

Copy link
Copy Markdown
Owner

Root cause

The Codex static-validation fixture inherited CODEX_HOME from the operator environment. Doctor queries plugin marketplaces only when it finds owned marketplace receipts: local developer receipts produced three commands, while an empty CI home produced two. PR #827 changed the assertion to depend on that incidental local state.

Fix

Inject an empty environment into this one runDoctor fixture and assert exactly the version and plugin-list probes. Keep the corruption and AB7319/AB6032 validation assertions unchanged. No production changes, release changeset, or consumer preview update is needed.

Verification

  • Before fixing: Node 26.8.1 with CODEX_HOME unset and CI=true reproduced expected-three/actual-two failure; inherited local Node 24.15.0 passed.
  • After fixing: all 76 doctor tests passed in both clean Node 26.8.1 and inherited local Node 24.15.0 environments.
  • pnpm build: passed.
  • pnpm typecheck: passed.
  • pnpm lint: passed.
  • pnpm test:unit --hideSkippedTests --reporters dot: 311 files passed, 4483 tests passed, 6 skipped.
  • pnpm changeset status --since=origin/main --verbose: passed, no packages to bump.
  • git diff --check: passed.
  • Branch contains current origin/main 10485c4.
  • Independent parent review cleared the exact test-only diff.

Parent owns merge and post-merge verification.

@changeset-bot

changeset-bot Bot commented Sep 18, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 2d4e56a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 18, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-18T22:56:10.197238Z 2d4e56a PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@ScriptedAlchemy
ScriptedAlchemy merged commit b0b131b into main Sep 18, 2026
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant