Skip to content

fix(ci): preserve generated executables in release commits - #260

Merged
ScriptedAlchemy merged 3 commits into
masterfrom
codex/release-generated-executables
Sep 18, 2026
Merged

ScriptedAlchemy merged 3 commits into
masterfrom
codex/release-generated-executables

Conversation

@ScriptedAlchemy

@ScriptedAlchemy ScriptedAlchemy commented Sep 18, 2026

Copy link
Copy Markdown
Owner

Fix

Set the pinned Changesets action's push-with-git-cli: true input so version PR commits retain generated executable modes. Its default GitHub API rejects artifact/bin/cargo-hauler.mjs (100755); postmerge Release run 35403412782 passed all check/build/artifact validation steps, then failed creating the version PR. Publication did not run.

Also remove the duplicate CI refresh job and move its commit step directly after pnpm check in the serialized release job, before Changesets. One workflow now owns generated output and release-branch creation, avoiding concurrent CI/main refresh and Changesets writers. Existing checks already build and validate the artifact, so the deleted job's extra install/build are unnecessary.

Actions OIDC publishing, generated bytes/modes, versioning, and installation remain untouched. Installation docs identify the release workflow as the refresh owner.

Verification

  • actionlint .github/workflows/ci.yml .github/workflows/release.yml: passed.
  • Workflow ownership assertions: CI has no refresh job/writes; release has contents-write permission, uncancelled serialized concurrency, and its generated-output commit step follows checks and immediately precedes Changesets. pnpm check still builds and validates artifacts.
  • Parsed current workflow and pinned Changesets action schema/runtime: input is supported and parsed by core.getBooleanInput; enabled path uses native git add, git commit, and branch push rather than commitChangesSinceBase.
  • Committed the actual generated artifact/bin/cargo-hauler.mjs into a disposable Git repository, pushed it to a local bare changeset-release/master branch, and verified remote tree mode remains 100755.
  • Bot-refreshed master artifact 5ad90c1: archived only native root marketplaces and artifact/ (no source/dependencies), validated through agent-bundle validate --artifact, ran CLI help, and asserted all three marketplaces resolve to the executable root; passed.
  • git diff --check: passed. No source/generated files or package versions authored; no local publication or installation performed.

Parent coordinator owns independent review and merge. After merge, the release workflow must complete its version PR creation before the repair is considered remotely verified.

@changeset-bot

changeset-bot Bot commented Sep 18, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 999e46d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 18, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-18T23:03:50.983169Z 9795288 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@ScriptedAlchemy
ScriptedAlchemy merged commit e825d6f into master Sep 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant