Conversation
- GVA is not defined on the surface: removed from SurfaceOperationalStatusV1Msg - SDA introduced in ADS-B V2: moved from Airborne/SurfaceOperationalStatusV1Msg to Airborne/SurfaceOperationalStatusV2Msg - GVA introduced in ADS-B V2: moved from AirborneOperationalStatusV1Msg to AirborneOperationalStatusV2Msg - NIC suppl C introduced in ADS-B V2: moved from SurfaceOperationalStatusV1Msg to SurfaceOperationalStatusV2Msg
Correct Capability Class Code parsing for ADS‑B v0/v1/v2; add BitReader and tests: - Parse all Operational Status fields with `BitReader` to fix bit offsets and endian handling. - Correct extraction of `subtype`, `capability_class_code`, `operational_mode_code`, and `version`. - Align `NIC supplement`, `NACp`, `SIL`, `NIC baro/track`, and `HRD` flags with DO‑260A/B. - Airborne V1 (`AirborneOperationalStatusV1Msg`): - Fix `hasOperationalTCAS()` logic per capability bit semantics. - Correct masks for Air‑Referenced Velocity and Target State Report. - Expose BAQ and NIC baro flags. - Rename 1090ES IN capability to CDTI presence for clarity. - Surface V1 (`SurfaceOperationalStatusV1Msg`): - Correct 12‑bit `capability_class_code` parsing and related flags. - Replace 1090ES IN with `hasOperationalCDTI()`; add `hasPositionOffsetApplied()` (POA). - Keep length/width decoding per DO‑260B Table 2‑74; tidy Javadoc and formatting. - V0 (`OperationalStatusV0Msg`): documentation/formatting cleanups; no logic changes beyond style. - V2 classes: minor consistency/formatting updates; no behavioral changes intended. - Example: update `ExampleDecoder` to new API (`hasOperationalCDTI`). - Add `BitReader` utility and `BitReaderTest` covering cross‑byte and variable‑width reads. Fixes: Capability Class Codes for different ADS‑B versions were not assigned correctly BREAKING CHANGE: - `AirborneOperationalStatusV1Msg`: `has1090ESIn()` renamed to `hasOperationalCDTI()`; semantics clarified. - `SurfaceOperationalStatusV1Msg`: `has1090ESIn()` renamed to `hasOperationalCDTI()`; `hasPositionOffsetApplied()` added. - Some previously exposed fields/methods tied to misinterpreted
Moved `single antenna` and `GPS antenna offset` flags from V1 to V2 operational status messages.
Contributor
Author
|
fixes #30 |
Member
I wonder if this is necessary
Considering that is is a breaking change, I'd discourage renaming. |
The flag is named 1090ES IN in V1 and V2. In V0, there was a flag that didn't really have a name but its semantics were described as "CDTI not Operational or unknown" / "CDTI Operational" Renaming a flag from its modern name to a name that was not declared as such does not clarify semantics --> reverting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed Operational Mode Codes
Moved
single antennaandGPS antenna offsetflags from V1 to V2operational status messages.
Fixed Capability Class Codes
Correct Capability Class Code parsing for ADS‑B v0/v1/v2; add BitReader
and tests:
BitReaderto fix bitoffsets and endian handling.
subtype,capability_class_code,operational_mode_code, andversion.NIC supplement,NACp,SIL,NIC baro/track, andHRDflags with DO‑260A/B.
AirborneOperationalStatusV1Msg):hasOperationalTCAS()logic per capability bit semantics.SurfaceOperationalStatusV1Msg):capability_class_codeparsing and related flags.hasOperationalCDTI(); addhasPositionOffsetApplied()(POA).formatting.
OperationalStatusV0Msg): documentation/formatting cleanups; nologic changes beyond style.
changes intended.
ExampleDecoderto new APIBitReaderutility andBitReaderTestcovering cross‑byte andvariable‑width reads.
Fixes: Capability Class Codes for different ADS‑B versions were not
assigned correctly
BREAKING CHANGE:
AirborneOperationalStatusV1Msg:
has1090ESIn()renamed tohasOperationalCDTI();SurfaceOperationalStatusV1Msg:has1090ESIn()renamed tohasOperationalCDTI();hasPositionOffsetApplied()added.