Conversation
Contributor
ACK. The next release will already have breaking API changes. No need to keep old cruft. |
fixje
requested changes
Mar 16, 2026
src/main/java/de/serosystems/lib1090/msgs/adsb/AirbornePositionV0Msg.java
Show resolved
Hide resolved
src/main/java/de/serosystems/lib1090/msgs/adsb/SurfacePositionV0Msg.java
Outdated
Show resolved
Hide resolved
src/main/java/de/serosystems/lib1090/msgs/adsr/AirbornePositionV0Msg.java
Outdated
Show resolved
Hide resolved
src/main/java/de/serosystems/lib1090/msgs/adsr/SurfacePositionV0Msg.java
Outdated
Show resolved
Hide resolved
src/main/java/de/serosystems/lib1090/msgs/tisb/CoarsePositionMsg.java
Outdated
Show resolved
Hide resolved
src/main/java/de/serosystems/lib1090/msgs/tisb/FineAirbornePositionMsg.java
Outdated
Show resolved
Hide resolved
src/main/java/de/serosystems/lib1090/msgs/tisb/FineSurfacePositionMsg.java
Outdated
Show resolved
Hide resolved
Member
Author
Additional Changes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: this is a API breaking change!
API
CompactPositionReportingdeleted. Its two static methods (local and global decoding) are now part ofCPREncodedPositionCPREncodedPositionhas a new flagIt would be possible to supply
@Deprecatedversions for those 3 changes, but I don't think that anyone used those methods directly. Also any broken calls can easily be ported to the new API.Changes
Not altering behavior
NLfunctionAll changes are done by mathematical equivalences and do not change the algorithms, except for cases where the old implementation produced wrong results due to limited precision (if any).
All tests have been adapted (API wise) and pass.
Altering behavior
decodeGlobal, because the constraints on timestamps is actually a prerequisite of the algorithm to produce correct results.It is still possible to disable those tests having
timestamp = nullbut it is not encouraged (nor used by libadsb).null(i.e. global decoding fails then)Final note
The
decodePositionmethod has been left as-is (some tests moved but are still all in effect).The reasonable tests are still not compliant with
// see A.1.7.10.2 of DO-260B, so you might want to change that comment. The tests are rather inspired by the standard.