Dan and Sage seattle.rb code retreat

[ragesoss]

No description provided.

[phiggins]

Hey, here's a small bit of code review.

• each_cons will only ever generate arrays of the requested size, so the length check is unnecessary.

• Ruby's destructuring can be used to get rid of some of these array accesses and make the code a little easier to read.

• Hash.new takes a block that is run when an element is looked up and not found, that can be used to set a default value.

Putting it all together, you could rewrite this method to look something like:

def build_frequency_hash
  @hash = Hash.new {|h,k| h[k] = [] }
  @words.each_cons(2) do |word, follower|
    @hash[word] << follower
  end
end

If you wanted to make this a stateless function, you could get even crazier:

def build_frequency_hash(words)
  words.each_cons(2).with_object(Hash.new {|h,k| h[k] = [] }) do |(word, follower), hash|
    hash[word] << follower
  end
end

Your code is fine, now I'm just golfing. ;)

[phiggins]

This is great, thanks for sharing! 👍