DEFEAT RECAPTCHA - #26
Conversation
| time.sleep(1.5) | ||
| driver.find_element_by_xpath(ACCEPT_BUTTON).click() | ||
| time.sleep(2) | ||
| googleClass = driver.find_elements_by_class_name(CAPTCHA_BOX)[0] |
There was a problem hiding this comment.
I'm almost wondering if a different function should be implemented for handling captchas outside of generate_account. Maybe the same code in a handle_captcha function with param driver? It's nitpicky, and the PR should still be accepted if the change isn't implemented, but I think readability could improve a bit.
pws1453
left a comment
pws1453
left a comment
There was a problem hiding this comment.
Besides the note in main.py about creating a separate function for captcha handling, code runs great. Your code readability and quality is excellent. As a university student, I've been taking notes about it. @SeanDaBlack, please merge into main whenever possible.
jmrushing
left a comment
jmrushing
left a comment
There was a problem hiding this comment.
I tested your additions on my fork, works great.
I do agree with other suggestions and PRs that we need multi-threading, a resume pdf generator, more code cleanup (what's been done looks great so far though), also need targeted phone number generation (these wacky area codes and extensions are easily filtered out), BUT these are all general gripes and not your fault - this PR should be accepted IMO 😁
|
This does the same as #28 |
4 participants
IMPLEMENTED FIX FOUND HERE