Respect required CI checks#10
Open
lukelabonte wants to merge 5 commits into
Open
Conversation
Show approval-gated non-blocking checks separately while keeping merge status based on required GitHub checks.
SeanMcTex
requested changes
May 11, 2026
Owner
SeanMcTex
left a comment
There was a problem hiding this comment.
Thanks a bunch for the submission! Would definitely like to avoid CircleCI-specific code if at all possible, since not everyone uses it. I'd be glad for your thoughts.
Use statusCheckRollup.state when required metadata and individual checks are unavailable, including EXPECTED as pending. Expand required-CI and parameterized test coverage around the fallback paths.
Treat not-started required CI as needing attention and avoid counting waiting approval parent checks as active CI work.
Author
|
I pushed another pass based on the review. What changed:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This updates MonitorLizard so the main PR status is based on the checks GitHub actually treats as required.
Before this, optional checks could make a PR look blocked even when GitHub would allow it to merge. That was noisy for repos that use approval-gated CircleCI workflows. Now required checks drive the main status, and approval-gated non-blocking checks show up on a separate line.
What changed
Non-blocking: 1 waiting for approval.Screenshots
Verification
xcodebuild -project "MonitorLizard/MonitorLizard.xcodeproj" -scheme "MonitorLizard" -configuration Debug CODE_SIGNING_ALLOWED=NO buildgit diff --checkI also tried a focused test run for the GitHub service tests. The test bundle still fails to compile because of existing Swift 6 actor-isolation errors in
PRMonitorViewModelTests.swift, so those tests don't get far enough to run yet.