Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/opengl/experimental/test/TestBatchRenderingTexture2D.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,7 @@ test::TestBatchRenderingTexture2D::TestBatchRenderingTexture2D()
glm::vec3{ 4.F, 0.F, 0.F } + offset, colors[2], 3);

m_vertex_buffer = glengine::VertexBuffer{ vertices };
constexpr auto quad_size = std::size(glengine::Quad{});
const auto quad_count = std::size(vertices) / quad_size;
const auto quad_count = std::size(vertices) / glengine::VerticesPerQuad;
m_index_buffer
= glengine::IndexBuffer{ glengine::QuadIndices(quad_count) };

Expand Down
3 changes: 1 addition & 2 deletions src/opengl/glengine/glengine/Vertex.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -52,14 +52,13 @@ std::vector<std::uint32_t> QuadIndices(std::size_t count)
{
std::vector<std::uint32_t> indices{};
indices.reserve(std::size(QuadIndicesInit) * count);
static constexpr auto quad_size = std::size(Quad{});
for (std::size_t i{}; i != count; ++i)
{
std::ranges::transform(
QuadIndicesInit,
std::back_inserter(indices),
[&i](std::uint32_t index)
{ return static_cast<std::uint32_t>(index + i * quad_size); });
{ return static_cast<std::uint32_t>(index + i * VerticesPerQuad); });
}
return indices;
}
Expand Down
22 changes: 11 additions & 11 deletions src/opengl/glengine/glengine/Vertex.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,8 @@ static_assert(
&& std::default_initializable<Vertex>);

using Quad = std::array<Vertex, 4U>;
inline constexpr std::size_t VerticesPerQuad =
std::tuple_size_v<Quad>;
static constexpr auto QuadIndicesInit
= std::array<std::uint32_t, 6U>{ 0, 1, 2, 2, 3, 0 };

Expand All @@ -51,7 +53,6 @@ constexpr inline std::array<
{
using std::ranges::size;
std::array<std::uint32_t, count * size(QuadIndicesInit)> indices{};
constexpr auto quad_size = size(Quad{});
for (std::size_t i{}; i != count; ++i)
{
using std::ranges::range_difference_t;
Expand All @@ -67,7 +68,7 @@ constexpr inline std::array<
QuadIndicesInit,
f,
[&](std::uint32_t index)
{ return static_cast<std::uint32_t>(index + i * quad_size); });
{ return static_cast<std::uint32_t>(index + i * VerticesPerQuad); });
}
return indices;
}
Expand All @@ -79,15 +80,14 @@ Quad CreateQuad(
const float tiling_factor = 1.F,
const std::array<
glm::vec2,
4U> uv
= { glm::vec2{ 0.F,
0.F },
glm::vec2{ 1.F,
0.F },
glm::vec2{ 1.F,
1.F },
glm::vec2{ 0.F,
1.F } },
4U> uv = { glm::vec2{ 0.F,
0.F },
glm::vec2{ 1.F,
0.F },
glm::vec2{ 1.F,
1.F },
glm::vec2{ 0.F,
1.F } },
const glm::vec2 size = { 1.F,
1.F },
const int id = -1,
Expand Down
2 changes: 1 addition & 1 deletion src/opengl/glengine/glengine/VertexBufferDynamic.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ class VertexBufferDynamic
* sizeof(std::ranges::range_value_t<T>)),
std::ranges::data(vertices));
return glengine::IndexBufferDynamicSize(
(std::ranges::size(vertices) / std::size(Quad{}) * IndicesPerQuad));
(std::ranges::size(vertices) / VerticesPerQuad * IndicesPerQuad));
}
};
static_assert(Bindable<VertexBufferDynamic>);
Expand Down
Loading