Use simflags string for simulation options instead of setSimulationOp…#1
Open
BartgeierXC wants to merge 1 commit into
Open
Use simflags string for simulation options instead of setSimulationOp…#1BartgeierXC wants to merge 1 commit into
BartgeierXC wants to merge 1 commit into
Conversation
…tions With the recent OpenModelica update to v1.26.2, setSimulationOptions doesn't recognice timing parameters any more. Introduced fix: Replace calls to setSimulationOptions with a constructed simflags string that includes timing parameters (-startTime, -stopTime, -stepSize, -tolerance) and appends any existing flags. Applied to run_simulation_in_order and simulate_model_worker so model.simulate is invoked with simflags=sim_options (and resultfile where applicable). This centralizes simulation options into the simflags parameter and removes the previous setSimulationOptions usage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…tions
With the recent OpenModelica update to v1.26.2, setSimulationOptions doesn't recognice timing parameters any more. Introduced fix:
Replace calls to setSimulationOptions with a constructed simflags string that includes timing parameters (-startTime, -stopTime, -stepSize, -tolerance) and appends any existing flags. Applied to run_simulation_in_order and simulate_model_worker so model.simulate is invoked with simflags=sim_options (and resultfile where applicable). This centralizes simulation options into the simflags parameter and removes the previous setSimulationOptions usage.