fix(deps): guard sibling-detection against .build/checkouts false-positive#27
Merged
Conversation
…itive
The occtDep helper used a local `.package(path: "../<name>")` whenever
`../<name>/Package.swift` existed. SwiftPM lays every transitive checkout out
flat under one `.build/checkouts/`, so when this manifest is itself resolved as
a dependency, `../<name>` spuriously exists and flips the dep to a path — which
conflicts with the same package resolved by URL elsewhere in the graph, so
SwiftPM emits a "Conflicting identity" warning (slated to become a hard error).
Guard the sibling branch with `!manifestDir.contains("/.build/")` so only a real
local dev clone takes the path dep. Mirrors SecondMouseAU/OCCTSwiftScripts#70.
Refs SecondMouseAU/ecosystem#14.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
occtDephelper takes a local.package(path: "../<name>")whenever../<name>/Package.swiftexists. SwiftPM lays every transitive checkout out flat under one.build/checkouts/, so when this package is resolved as a dependency,../<name>spuriously exists and the dep flips to a path — conflicting with the same package resolved by URL elsewhere, producing SwiftPMConflicting identitywarnings that are slated to become hard errors.Fix: guard the sibling branch with
!manifestDir.contains("/.build/")so only a real local dev clone uses the path dep. Mirrors SecondMouseAU/OCCTSwiftScripts#70.Refs SecondMouseAU/ecosystem#14.
🤖 Generated with Claude Code