CI: Competency#929
Draft
itssaharsh wants to merge 1 commit into
Draft
Conversation
Contributor
|
NACK. See: #931 Also note the copy-paste miss from your AI in the PR description. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Problem or Issue being addressed
This PR completes the competency test requirement for property-based testing on PSBTParser.
Current tests validate parser behavior with hand-crafted fixtures, but the accounting invariant was not exercised under a property-style repeated replay harness.
Solution
I added one focused Hypothesis test that replays the four existing known-good single-sig PSBT fixtures for 100 generated examples and validates the core invariant:
input_amount = spend_amount + change_amount + fee_amount
I also added Hypothesis to test dependencies.
Changed files:
Competency Evidence
Additional Information
Scope is intentionally minimal and mergeable for the competency test only.
Not included in this PR:
Screenshots
N/A. No UI changes.
This pull request is categorized as a:
Checklist
I ran pytest locally
I included screenshots of any new or modified screens
Should be part of the PR description above.
I added or updated tests
Any new or altered functionality should be covered in a unit test. Any new or updated sequences require FlowTests.
I tested this PR hands-on on the following platform(s):
I have reviewed these notes:
If you want, I can also give you a second version optimized for stricter maintainers with an even shorter summary and stronger risk language.You've used 67% of your session rate limit. Your session rate limit will reset on April 25 at 2:24 PM. Learn More