Update seedsigner-translations submodule to latest dev (9a76a81)#932
Open
Chaitanya-Keyal wants to merge 4 commits into
Open
Update seedsigner-translations submodule to latest dev (9a76a81)#932Chaitanya-Keyal wants to merge 4 commits into
Chaitanya-Keyal wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the
seedsigner-translationssubmodule to the latestdevcommit (SeedSigner/seedsigner-translations@9a76a81).Additionally, this PR fixes CI run failures that emerged with this submodule update. In recent changes to the
seedsigner-translationsrepo, the compiled.mofiles were removed from version control. Because the tests workflow in this repository did not have thecompile_catalogstep (unlike our other workflows), the.mofiles were entirely absent during tests.Additional Information / CI Changes
setuptoolsto requirements-l10n.txt: Our translation compilation relies onsetup.py, but starting in Python 3.12,setuptoolsis no longer bundled by default viaensurepip/venv. Adding it explicitly ensures the Python 3.12+ matrix builds succeed without throwingModuleNotFoundError: No module named 'setuptools'.tests.ymlto explicitly installl10n/requirements-l10n.txtand runpython setup.py compile_catalogright before executing the tests to generate the missing.mofiles.pip install -e .(editable mode). This ensures that the newly compiled.mofiles generated directly inside thesrcdirectory are immediately available and resolvable bypytest.All these changes make the tests workflow in this repo similar to the translations repo's workflow.
This pull request is categorized as a:
Checklist
I ran
pytestlocallyI included screenshots of any new or modified screens
I added or updated tests
I tested this PR hands-on on the following platform(s):
I have reviewed these notes: