Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds logging statements to the process_sheet_by_content method in the sheet scorer to track when sheets are received and when results are being returned. This supports observability and debugging of the sheet scoring process.
Changes:
- Added entry log when a sheet is received for scoring
- Added exit log before returning successful GPT-based scoring results
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| return self.create_failure_output(sheet_id=sheet_id, | ||
| request_status_message=request_status_message) | ||
|
|
||
| logger.info(f"Returning results for sheet {sheet_id}") |
There was a problem hiding this comment.
The log message "Returning results for sheet {sheet_id}" is misleading because it only covers the successful return path. The function has other return paths at lines 755, 770, and 792 that also return results. Consider using a more specific message like "Successfully scored sheet {sheet_id}" or "Returning successful GPT-based scores for sheet {sheet_id}" to clarify that this log applies only to the successful GPT analysis path.
| logger.info(f"Returning results for sheet {sheet_id}") | |
| logger.info(f"Returning successful GPT-based scores for sheet {sheet_id}") |
1 participant
No description provided.