Wrap refs to anchor elemnts with data-target-module attrbute#3085
Open
YishaiGlasner wants to merge 3 commits intomasterfrom
Open
Wrap refs to anchor elemnts with data-target-module attrbute#3085YishaiGlasner wants to merge 3 commits intomasterfrom
YishaiGlasner wants to merge 3 commits intomasterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates server-side ref auto-linking so generated <a class="refLink"> tags include a data-target-module attribute, allowing the frontend router to open links in the correct module (Library vs Voices) and addressing incorrect navigation for links shown on Voices pages.
Changes:
- Add
data-target-moduleto auto-wrapped ref links. - Determine module target based on whether the ref points to a Sheet (
voices) vs standard text (library).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
stevekaplan123
previously requested changes
Feb 11, 2026
Contributor
stevekaplan123
left a comment
stevekaplan123
left a comment
There was a problem hiding this comment.
We should avoid using magic strings if we can. Don't we have constants with the values "voices"/"library"?
🧪 CI InsightsHere's what we observed from your CI run for 2090ca8. 🟢 All jobs passed!But CI Insights is watching 👀 |
yitzhakc
approved these changes
Feb 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
That will solve the bug with Nechama's links open on voices