-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Proposed plan for Selenium 5 #2556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
titusfortner
wants to merge
1
commit into
trunk
Choose a base branch
from
proposals
base: trunk
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| # Plan for Selenium 5 | ||
|
|
||
| Selenium needs a major release to highlight new features, and ensure all bindings are being managed consistently. | ||
| As such, the plan is to do a minimal focused Selenium 5 release making sure everyone is on the same page. | ||
|
|
||
| ## In scope | ||
| These items must be done before release | ||
| - New high-level async/event APIs (consistent concept across bindings, idiomatic per language) in all bindings | ||
| - Selenium Manager released with stable API, independent of Selenium version | ||
| - Established cross-bindings guidelines for how Selenium API is implemented with BiDi | ||
|
|
||
| ## Out of Scope | ||
| These items may be done after Selenium 5 is released | ||
| - Implementing all Selenium APIs with BiDi commands | ||
| - Deprecating CDP code | ||
| - Major breaking changes | ||
|
|
||
| ## Principles | ||
|
|
||
| ### Backwards compatibility | ||
| The goal is minimum annoyance for users to upgrade | ||
| - Users should not need to make significant changes to their test code | ||
| - Existing Selenium deprecation policy applies to Selenium 5: only remove code that was deprecated for > 2 previous minor versions. | ||
| - Orchestration changes and dependency changes that cannot be deprecated may be acceptable | ||
|
|
||
| ### BiDi implementation | ||
| BiDi is not a new Selenium API, it provides better tools for implementing and extending the existing API | ||
| - No references to BiDi in the API (casting or namespacing) | ||
| - Users can access BiDi implementation code, but it is clearly marked as internal usage / likely to change | ||
| - Enabling BiDi cannot break current Selenium API (requires graceful fallback) | ||
| - Maintain consistent approach across bindings | ||
|
|
||
| ## Implementation | ||
| The specific details for how these features are implemented and are managed across bindings will be managed | ||
| by GitHub Issues. Any issues with disagreements or that needs additional discussion or approval will be labeled as `A-needs-decision` | ||
| and discussed at the next TLC meeting. | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.