Skip to content

Fix action manifests#242

Merged
kariharju merged 9 commits into
mainfrom
fix-spcs-action-manifest
Oct 29, 2025
Merged

Fix action manifests#242
kariharju merged 9 commits into
mainfrom
fix-spcs-action-manifest

Conversation

@kariharju
Copy link
Copy Markdown
Contributor

@kariharju kariharju commented Oct 24, 2025

Description

At some point the action manifest logic lost the history versions of the action packages

Added a renegeration logic that rebuilds the manifest based on S3 content and whitelist json.

This is a manual process as we should not need to do this, basically ever.
This requires downloading the S3 actions folder content locally

The update scripting was/is working correctly, but as it relies on the manifest.json, if a broken manifest gets published the update keeps building on top of that.

  • Dropped the sai manifest generation that was confusing the logic.
  • Dropped "build all packages" as that would break the manifest totally (potential reason for this)
  • Unprettified the result JSONS (json size from 1,5MB to 800KB) affects Studio responsiveness directly.

How can (was) this tested?

Studio before:
image

Studio after (not linked):
image

Studio after (SF linked):
image

Screenshots (if needed)

Checklist:

  • I have bumped the version number for the Action Package / Agent
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation - README.md file
  • I have updated the CHANGELOG.md file in correspondence with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • OAuth2: I have made sure that action has necessary scopes (works in whitelisted mode)

@kariharju kariharju marked this pull request as ready for review October 27, 2025 14:12
Added Readme for publisher project
@kariharju
Copy link
Copy Markdown
Contributor Author

@codex review

Copy link
Copy Markdown

@mmokko mmokko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some comments to make the code a bit safer. Consider using os.walk or os.scandir instead of os.listdir for efficiency.

I'll approve this regardless of comments. There were no immediate issues that I found.

Comment thread bin/publisher/regenerate_manifests.py Outdated
Comment thread bin/publisher/regenerate_manifests.py
Comment thread bin/publisher/regenerate_manifests.py Outdated
Comment thread bin/publisher/regenerate_manifests.py Outdated
Comment thread bin/publisher/regenerate_manifests.py Outdated
Comment thread bin/publisher/regenerate_manifests.py Outdated
- version pattern check
- use os.walk
- Fix all 'with open()' to have utf encoding and linefeeds
- Improved manifest json file skips
@kariharju kariharju merged commit 477ffed into main Oct 29, 2025
12 checks passed
@kariharju kariharju deleted the fix-spcs-action-manifest branch October 29, 2025 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants